fix(files): do not display hidden files count on public shares - #64085
Open
fauzanfebrian wants to merge 1 commit into
Open
fix(files): do not display hidden files count on public shares#64085fauzanfebrian wants to merge 1 commit into
fauzanfebrian wants to merge 1 commit into
Conversation
fauzanfebrian
requested review from
kristian-zendato and
sorbaugh
and removed request for
a team
September 6, 2026 13:12
fauzanfebrian
force-pushed
the
fix/39027-public-share-hidden-files-count
branch
from
September 6, 2026 13:18
da237a4 to
4d16404
Compare
Hidden files visibility can be configured internally, but on public shares this information is irrelevant and leaks the presence of hidden files. This passes the isPublic flag to getSummaryFor to skip generating the hidden files summary. Fixes nextcloud#39027 Assisted-by: Antigravity:Gemini-3.1-Pro Signed-off-by: Fauzan Febriansyah <fauzanfebriann@gmail.com>
fauzanfebrian
force-pushed
the
fix/39027-public-share-hidden-files-count
branch
from
September 6, 2026 13:50
4d16404 to
e6fe4df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request removes the display of the hidden files count in the summary on public share pages.
While dot files are already hidden in the public grid/list view, the footer summary was still displaying "X hidden". Since public users do not have access to toggle the visibility of hidden files via a gear icon, showing this helper text is unnecessary and leaks metadata about the presence of hidden files.
This change modifies
getSummaryForinfileUtils.tsto accept ahideHiddenStringargument, and leverages the existingisPublicprop inFilesList.vueto skip appending the hidden files string when rendering a public share.Screenshots (Before / After)
Public Share Link (The Fix)
Internal Logged-in View (Regression Check)
TODO
isPublicflag togetSummaryForgetSummaryForwith new argumentsChecklist
3. to review, feature component)stable32)AI (if applicable)