fix(chat): do not separate edited messages from the group - #19006
Open
Antreesy wants to merge 3 commits into
Open
fix(chat): do not separate edited messages from the group#19006Antreesy wants to merge 3 commits into
Antreesy wants to merge 3 commits into
Conversation
Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- if both are users, avatar wasn't shown Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
- including list view - remove duplicate string next to display name Assisted-by: ClaudeCode:claude-sonnet-5 Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
added
bug
design
feature: chat 💬
DorraJaouad
reviewed
Aug 17, 2026
Comment on lines
504
to
509
| isEditorDifferentThenAuthor() { | ||
| return this.message.lastEditActorId | ||
| && this.message.lastEditActorId !== this.message.actorId | ||
| && this.message.lastEditActorDisplayName !== this.message.actorDisplayName | ||
| && this.message.lastEditActorType !== this.message.actorType | ||
| && (this.message.lastEditActorId !== this.message.actorId | ||
| || this.message.lastEditActorType !== this.message.actorType) | ||
| }, |
Contributor
There was a problem hiding this comment.
two different users with the same name will pass this and will be read as self-edited
Contributor
Author
There was a problem hiding this comment.
So then we should fully remove displayName condition? actorId+actorType pair is unique enough
| color: var(--color-text-maxcontrast); | ||
| font-size: var(--default-font-size); | ||
| width: $messages-info-width; | ||
| min-width: $messages-info-width; |
Contributor
There was a problem hiding this comment.
this is not reset in split mode css classes. So instead of width: auto , min-width: 0; needs to be added there --sided (line 692) and --compressed-system (line 673)
| const firstMessage = computed(() => messages.value[0]) | ||
| const { | ||
| remoteServer, | ||
| lastEditor, |
Contributor
There was a problem hiding this comment.
it was the only consumer of this computed. Instead of removing it, maybe keep it and add in aria label of the pencil icon?
Comment on lines
-595
to
-598
| if (!!message1.lastEditTimestamp || !!message2.lastEditTimestamp) { | ||
| return false // Edited messages are not grouped | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
There is a test test('does not group edited messages') to be removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
AI (if applicable)
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏁 Checklist