Skip to content

fix: correct progress for one-sided ranges #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ngocdevv merged 1 commit into from
Sep 4, 2026
Merged

fix: correct progress for one-sided ranges #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions packages/dial-slider/src/utils/dial-slider/ring-math.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,10 @@ interface Point {
y: number;
}

/** Bipolar fill: + side vs maxValue, − side vs |minValue|. */
/**
* Progress away from the neutral value. Neutral is zero when it is in range,
* otherwise the nearest range boundary.
*/
export function getBipolarProgress(
value: number,
minValue: number,
Expand All @@ -20,12 +23,18 @@ export function getBipolarProgress(
const min = Math.min(minValue, maxValue);
const max = Math.max(minValue, maxValue);
const clampedValue = Math.min(max, Math.max(min, value));
if (clampedValue >= 0) {
return max <= 0 ? 0 : Math.min(Math.max(clampedValue / max, 0), 1);
const neutral = Math.min(max, Math.max(min, 0));

if (clampedValue >= neutral) {
const positiveRange = max - neutral;
return positiveRange <= 0
? 0
: Math.min(Math.max((clampedValue - neutral) / positiveRange, 0), 1);
}
return min >= 0
const negativeRange = neutral - min;
return negativeRange <= 0
? 0
: Math.min(Math.max(Math.abs(clampedValue) / Math.abs(min), 0), 1);
: Math.min(Math.max((neutral - clampedValue) / negativeRange, 0), 1);
}

export function getSignedProgressColor(
Expand Down
10 changes: 10 additions & 0 deletions packages/dial-slider/tests/ring-math.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,16 @@ describe('preset progress ring', () => {
expect(getBipolarProgress(0, -100, 100)).toBe(0);
});

test('starts one-sided ranges at their nearest-to-zero boundary', () => {
expect(getBipolarProgress(10, 10, 20)).toBe(0);
expect(getBipolarProgress(15, 10, 20)).toBe(0.5);
expect(getBipolarProgress(20, 10, 20)).toBe(1);

expect(getBipolarProgress(-10, -20, -10)).toBe(0);
expect(getBipolarProgress(-15, -20, -10)).toBe(0.5);
expect(getBipolarProgress(-20, -20, -10)).toBe(1);
});

test('clamps progress and safely rejects non-finite configuration', () => {
expect(getBipolarProgress(500, -100, 100)).toBe(1);
expect(getBipolarProgress(-500, -100, 100)).toBe(1);
Expand Down