fix: replace removed solana.transaction imports with solders - #156
Open
Haaaarry wants to merge 1 commit into
Open
fix: replace removed solana.transaction imports with solders#156Haaaarry wants to merge 1 commit into
Haaaarry wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #135.
Problem
solana-py0.35 removed thesolana.transactionmodule (Transaction,Signature, andAccountMetamoved tosolders). Two files still import from it, so importing the package fails withModuleNotFoundError: No module named 'solana.transaction':agentipy/utils/moonshot/utils.py—from solana.transaction import Signatureagentipy/tools/use_moonshot.py—from solana.transaction import AccountMetaChange
Signature->solders.signature.SignatureAccountMeta->solders.instruction.AccountMetaBoth targets are already covered by the project's
soldersdependency (^0.21.0,<0.24.0), and these files already import other types fromsolders.*.Verification
python -m py_compilepasses for both files.solders==0.23.0thatSignature.from_string(...)andAccountMeta(pubkey=..., is_signer=..., is_writable=...)behave as the code expects.