Skip to content

CI: Add clang 21&22 to Ubuntu CLang build matrix - #5347

Merged
nlohmann merged 3 commits into
nlohmann:developfrom
petrbel:ci-ubuntu-add-clang-21
Aug 4, 2026
Merged

CI: Add clang 21&22 to Ubuntu CLang build matrix#5347
nlohmann merged 3 commits into
nlohmann:developfrom
petrbel:ci-ubuntu-add-clang-21

Conversation

@petrbel

@petrbel petrbel commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Current state: The Ubuntu CI build matrix (ci_test_compilers_clang) pins many Clang versions explicitly, but stops at Clang 20 before jumping to latest. Clang 21 was therefore only covered incidentally, via the latest tag.

Problem: silkeh/clang:latest has moved to Clang 22 and we've silently lost coverage of Clang 21.

Proposed change: Add an explicit 21 and 22 entries to the Ubuntu Clang build matrix. Both silkeh/clang:21 and silkeh/clang:22 images already exist.

Discussion: #5345 , Contribution Guidelines: Wanted

Scope: CI-only. No source, functionality, tests, docs, or coverage affected.


In case this is mandatory, I comply with Contribution Guidelines, namely Developer Certificate of Origin (DCO) version 1.1

@petrbel
petrbel requested a review from nlohmann as a code owner August 3, 2026 07:19
@petrbel
petrbel force-pushed the ci-ubuntu-add-clang-21 branch from 8525928 to e622d01 Compare August 3, 2026 09:51
@petrbel

petrbel commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

sorry about the push-force
I didn't know about mandatory sign off

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the CI is green, please also update the docs/mkdocs/docs/community/quality_assurance.md page with the new Clang version that shipped this morning for latest.

@petrbel
petrbel force-pushed the ci-ubuntu-add-clang-21 branch from 3a19dba to 5329473 Compare August 3, 2026 17:35
@petrbel petrbel changed the title CI: Add clang 21 to Ubuntu CLang build matrix CI: Add clang 21&22 to Ubuntu CLang build matrix Aug 3, 2026
@petrbel

petrbel commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Hi @nlohmann, thanks for review. I totally forgot that.

21.1.8 is already there but I added also 22.1.8 (not a typo, same minor/patch versions) because I happened to get my MR merged today and now there is also silkeh/clang:22. So now CI also builds both 21 and 22.

Hope it's fine now, please let me know if you want something changed.

@nlohmann

nlohmann commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Clang was updated and the latest develop branch fixes a CI issue. Please rebase to the latest develop branch.

@nlohmann nlohmann added the please rebase Please rebase your branch to origin/develop label Aug 4, 2026
petrbel added 3 commits August 4, 2026 10:50
Signed-off-by: Petr Belohlavek <me@petrbel.cz>
Signed-off-by: Petr Belohlavek <me@petrbel.cz>
Signed-off-by: Petr Belohlavek <me@petrbel.cz>
@petrbel
petrbel force-pushed the ci-ubuntu-add-clang-21 branch from 2a5c094 to 2e7e7c6 Compare August 4, 2026 08:52
@petrbel

petrbel commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Don't know why Windows / clang-cl-12 (Win32) failed. Maybe some network error?

  6/105 Test   #1: download_test_data .............................***Failed    2.67 sec

Unfortunatelly I'm not allowed to rerun the CI.

@nlohmann nlohmann left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann

nlohmann commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Thanks!

@nlohmann nlohmann removed the please rebase Please rebase your branch to origin/develop label Aug 4, 2026
@nlohmann nlohmann added this to the Release 3.13.0 milestone Aug 4, 2026
@nlohmann
nlohmann merged commit acd87e2 into nlohmann:develop Aug 4, 2026
188 of 189 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants