docs: use HTTPS for the astyle and cppcheck links in README - #5351
Merged
Conversation
Both links were still `http://`. `astyle.sourceforge.net` serves HTTPS directly; `cppcheck.sourceforge.net` redirects to `https://cppcheck.sourceforge.io`, which is also the URL already used in `docs/mkdocs/docs/community/quality_assurance.md`, so the redirect is skipped here. Signed-off-by: Niels Lohmann <mail@nlohmann.me>
nlohmann
added
the
🚀 ready to merge
gregmarr
approved these changes
Aug 4, 2026
Clang 22.1 (now shipped by silkeh/clang:latest) diagnoses __COUNTER__ as a C2y extension, and does so in C++ mode as well. Under -Weverything -Werror this breaks every ci_test_clang_cxx* / ci_test_clang_libcxx_cxx* target, independently of the code under test. The library itself does not use __COUNTER__; all diagnostics originate in vendored Doctest (DOCTEST_ANONYMOUS, used by TEST_CASE and SECTION). Signed-off-by: Niels Lohmann <mail@nlohmann.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two links in the README were still plain
http://:astyle.sourceforge.net— serves HTTPS directly, so it just becomeshttps://.cppcheck.sourceforge.net—https://cppcheck.sourceforge.net301-redirects tohttps://cppcheck.sourceforge.io, which is also the URL already used indocs/mkdocs/docs/community/quality_assurance.md. Linking there directly skips the redirect and keeps the two files consistent.Both targets were checked and return HTTP 200 over HTTPS.
This redoes #5280, which no longer exists (the author's account appears to have been removed).
Breaking changes to the public API
None — documentation only, no code or headers touched.
This pull request was prepared by Claude Code.