Fix FTBFS with OpenSSL 4 - #147
Open
vmpyr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #146
The bundled opensshlib files cipher-3des1.c and cipher-bf1.c implement the SSH protocol 1 "3des" and "blowfish" ciphers using the EVP_CIPHER_meth_*() API, which was deprecated in OpenSSL 3.0 and removed entirely in OpenSSL 4.0. Compiling them against OpenSSL 4 fails with implicit-declaration errors.
These ciphers are only referenced from cipher.c inside #ifdef WITH_SSH1 blocks, and Ncrack's build never enables SSH protocol 1 support (it does not pass --with-ssh1 to the bundled opensshlib configure), so this code is never actually used. Guard the affected code with WITH_SSH1 so it is compiled out, matching how its only consumers in cipher.c are already guarded. This keeps the package building with both OpenSSL 3 and OpenSSL 4.