Bug: Fix VBK sign for Nat_M case 6 - #773
Merged
Rick-Methot-NOAA merged 1 commit intoJul 22, 2026
Merged
Conversation
Collaborator
|
Good catch Nathan. I'll approve after the build failure is addressed. |
Collaborator
|
@Rick-Methot-NOAA and @nathanvaughan-NOAA, there is no reason that the windows build should fail, especially for the error that it's giving. I made the same small change in a branch and it built on all OS. I think we can chalk this up to a github actions quirk and merge it in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
This is a fix for the VBK sign change in natural mortality option 6
What tests have been done?
Where are the relevant files?
[x] No test files are required for this pull request.
What tests/review still need to be done?
Presumably the required tests for this change were already completed when the fix was made to case 2
Is there an input change for users to Stock Synthesis?
[x] No, there was no input change.
Additional information (optional).