Skip to content

Some elements of good practices implemented - #341

Draft
e-perl-NOAA wants to merge 1 commit into
mainfrom
docs-goodpractice
Draft

Some elements of good practices implemented#341
e-perl-NOAA wants to merge 1 commit into
mainfrom
docs-goodpractice

Conversation

@e-perl-NOAA

Copy link
Copy Markdown

This is not finished - see notes in issue #117

@github-actions

Copy link
Copy Markdown
Contributor

New version checklist

  • Package version in DESCRIPTION has been updated
  • Release notes have been drafted/published
  • Cheatsheet content has been updated (if applicable)
  • Cheatsheet version has been updated

@github-actions

Copy link
Copy Markdown
Contributor

Code Metrics Report

Coverage Code to Test Ratio Test Execution Time
67.9% 1:0.1 8m28s

Code coverage of files in pull request scope (66.4%)

Files Coverage
R/convert_output.R 53.9%
R/plot_biomass.R 81.0%
R/table_landings.R 97.1%
R/utils_plot.R 82.8%
R/utils_rda.R 80.3%
R/utils_table.R 68.7%

Reported by octocov

Comment thread R/utils_plot.R

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the filter_data should not be showing errors and have missing argument documentation because it is sharing the same documentation from spawning_biomass through inheritParams. I am curious why the check said this was missing

Comment thread R/convert_output.R

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to check if this is moved to utils. If so, can be removed, if not then this needs to stay. It is referenced in a couple lines below

@Schiano-NOAA Schiano-NOAA left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make the changes neccessary to merge this. Thanks @e-perl-NOAA for getting this started. This is a big help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants