Skip to content

fix(git-node): handle single-line commit messages#1059

Merged
aduh95 merged 3 commits intonodejs:mainfrom
aduh95:fix-single-line-commit
Apr 14, 2026
Merged

fix(git-node): handle single-line commit messages#1059
aduh95 merged 3 commits intonodejs:mainfrom
aduh95:fix-single-line-commit

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Apr 14, 2026

Fixes: #1058

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

❌ Patch coverage is 70.45455% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.74%. Comparing base (a9048c8) to head (d941035).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/landing_session.js 70.45% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   80.56%   71.74%   -8.83%     
==========================================
  Files          39       41       +2     
  Lines        4847     5878    +1031     
==========================================
+ Hits         3905     4217     +312     
- Misses        942     1661     +719     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 requested a review from richardlau April 14, 2026 09:11
@aduh95
Copy link
Copy Markdown
Contributor Author

aduh95 commented Apr 14, 2026

/cc @nodejs/node-core-utils the CQ is mostly broken without this, can I get some reviews?

Copy link
Copy Markdown
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aduh95 aduh95 merged commit f510b8a into nodejs:main Apr 14, 2026
11 of 13 checks passed
@aduh95 aduh95 deleted the fix-single-line-commit branch April 14, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tooling is confused by commits with title only

2 participants