Skip to content

src: allow empty --experimental-config-file#61610

Open
marco-ippolito wants to merge 1 commit intonodejs:mainfrom
marco-ippolito:default-config-json
Open

src: allow empty --experimental-config-file#61610
marco-ippolito wants to merge 1 commit intonodejs:mainfrom
marco-ippolito:default-config-json

Conversation

@marco-ippolito
Copy link
Copy Markdown
Member

This PR makes --experimental-config-file accept no arg.
When no arg is passed, it will default to node.config.json.
--experimental-default-config-file is just an alias of --experimental-config-file.
The reason for this change is so when stable we can just remove --experimental-default-config-file and rename --experimental-config-file to --config-file.
Users can execute node with node --config-file index.js or node --config-file=foo.json index.js.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 1, 2026
@marco-ippolito marco-ippolito force-pushed the default-config-json branch 2 times, most recently from 775234b to 9b00ced Compare February 1, 2026 09:36
Copy link
Copy Markdown
Member

@pmarchini pmarchini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmarchini pmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2026
@marco-ippolito marco-ippolito added the semver-minor PRs that contain new features and should be released in the next minor version. label Feb 1, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 1, 2026

Codecov Report

❌ Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.69%. Comparing base (3f52482) to head (4bf9c84).

Files with missing lines Patch % Lines
src/node.cc 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61610      +/-   ##
==========================================
- Coverage   91.55%   89.69%   -1.87%     
==========================================
  Files         356      706     +350     
  Lines      149601   218143   +68542     
  Branches    23395    41734   +18339     
==========================================
+ Hits       136967   195659   +58692     
- Misses      12371    14412    +2041     
- Partials      263     8072    +7809     
Files with missing lines Coverage Δ
lib/internal/process/pre_execution.js 98.38% <100.00%> (+14.63%) ⬆️
lib/internal/test_runner/runner.js 93.67% <100.00%> (+0.31%) ⬆️
src/node_config_file.cc 83.73% <100.00%> (ø)
src/node_config_file.h 100.00% <100.00%> (ø)
src/node_options.cc 76.61% <100.00%> (ø)
src/node_options.h 98.00% <ø> (ø)
src/node.cc 76.90% <87.50%> (ø)

... and 465 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marco-ippolito marco-ippolito force-pushed the default-config-json branch 4 times, most recently from 3dc9b42 to 2356e3a Compare February 1, 2026 14:35
Comment thread test/parallel/test-runner-flag-propagation.js
@marco-ippolito marco-ippolito force-pushed the default-config-json branch 3 times, most recently from bef68d1 to 5ce1d98 Compare April 15, 2026 10:48
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2026
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Failed to start CI
- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/71151/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/24459748339

@marco-ippolito marco-ippolito removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Apr 15, 2026
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 15, 2026
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Failed to start CI
- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/71151/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/24461444173

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@marco-ippolito marco-ippolito removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants