test: add more test cases for pathToFileURL

[RafaelGSS]

Just to make sure we won't introduce any regression anytime further (based on H1 reports we received).

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (c24e552) to head (51f1a25).
⚠️ Report is 195 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #63293      +/-   ##
==========================================
+ Coverage   90.05%   90.30%   +0.24%     
==========================================
  Files         714      730      +16     
  Lines      225247   234773    +9526     
  Branches    42578    43955    +1377     
==========================================
+ Hits       202842   212001    +9159     
- Misses      14181    14485     +304     
- Partials     8224     8287      +63     

see 164 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[aduh95]

According to https://url.spec.whatwg.org/#host-miscellaneous, there are a few more forbidden char we might as well check for:

Suggested change

	const forbiddenHostnameChars = [
	'\\\\exa mple\\share\\file.txt',
	'\\\\host name\\share\\file.txt', // space
	'\\\\host#name\\share\\file.txt', // hash
	'\\\\host?name\\share\\file.txt', // question mark
	'\\\\host@name\\share\\file.txt', // at sign
	'\\\\host:name\\share\\file.txt', // colon
	'\\\\host/name\\share\\file.txt', // forward slash
	'\\\\host[name\\share\\file.txt', // left bracket
	'\\\\host]name\\share\\file.txt', // right bracket
	];
	const forbiddenHostnameChars = Array.from('\0\t\n\r #:<>?@[]^|', (sep) => `\\\\host${sep}name\\share\\file.txt`);

But it looks like \n, \r, \t are ignored instead of being rejected; # and ? might have a special significant in UNC not sure

[aduh95]

I've opened ada-url/ada#1142 to address the # and ? cases

[RafaelGSS]

Ok, I will wait it to reach Node.js main, ping me please

[aduh95]

Sorry forgot to follow up, but the upstream issue was closed so let's limit to the ones that are supported

Suggested change

	const forbiddenHostnameChars = [
	'\\\\exa mple\\share\\file.txt',
	'\\\\host name\\share\\file.txt', // space
	'\\\\host#name\\share\\file.txt', // hash
	'\\\\host?name\\share\\file.txt', // question mark
	'\\\\host@name\\share\\file.txt', // at sign
	'\\\\host:name\\share\\file.txt', // colon
	'\\\\host/name\\share\\file.txt', // forward slash
	'\\\\host[name\\share\\file.txt', // left bracket
	'\\\\host]name\\share\\file.txt', // right bracket
	];
	const forbiddenHostnameChars = Array.from('\0 :<>@[]^|', (sep) => `\\\\host${sep}name\\share\\file.txt`);

[RafaelGSS]

Yes, that's why I sent 51f1a25. Honestly, it's much clearer to see that list than the approach you suggested.