Skip to content

test: make Brotli 16GB test wait for backpressure#63389

Open
trivikr wants to merge 2 commits into
nodejs:mainfrom
trivikr:flaky-test-zlib-brotli-16GB
Open

test: make Brotli 16GB test wait for backpressure#63389
trivikr wants to merge 2 commits into
nodejs:mainfrom
trivikr:flaky-test-zlib-brotli-16GB

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented May 17, 2026

This updates parallel/test-zlib-brotli-16GB to wait until the Brotli
decoder reaches the expected readable-buffer backpressure point
before asserting the buffered chunk count.

The previous test used a fixed timeout and could check _readableState.buffer.length
before libuv worker-pool processing had pushed any output, causing intermittent
failures like 0 !== 4 on loaded CI machines.

Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-17.md#jstest-failure


Assisted-by: openai:gpt-5.5

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 17, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (4639dcb) to head (143affe).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63389      +/-   ##
==========================================
+ Coverage   90.29%   90.31%   +0.02%     
==========================================
  Files         730      730              
  Lines      234695   234695              
  Branches    43956    43957       +1     
==========================================
+ Hits       211927   211975      +48     
+ Misses      14494    14436      -58     
- Partials     8274     8284      +10     

see 47 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label May 17, 2026
Comment thread test/parallel/test-zlib-brotli-16GB.js Outdated
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2026
@nodejs-github-bot

This comment was marked as outdated.

trivikr added 2 commits May 27, 2026 22:06
Wait for the Brotli decoder to fill its readable buffer before checking
that decompression stops at the high water mark. This avoids racing the
fixed timeout against libuv worker-pool scheduling.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: openai:gpt-5.5
@trivikr trivikr force-pushed the flaky-test-zlib-brotli-16GB branch from a6f7f6e to 143affe Compare May 28, 2026 05:06
@trivikr trivikr requested a review from aduh95 May 28, 2026 05:07
@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants