Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/internal/test_runner/runner.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,11 @@ const kDiagnosticsFilterArgs = ['tests', 'suites', 'pass', 'fail', 'cancelled',
const kCanceledTests = new SafeSet()
.add(kCancelledByParent).add(kAborted).add(kTestTimeoutFailure);

// Execution-ordered events are forwarded immediately, bypassing the
// per-file declaration-order buffer.
const kExecutionOrderedEvents = new SafeSet()
.add('test:enqueue').add('test:dequeue').add('test:complete');

let kResistStopPropagation;

// Worker ID pool management for concurrent test execution
Expand Down Expand Up @@ -331,6 +336,10 @@ class FileTest extends Test {
}
}
addToReport(item) {
if (kExecutionOrderedEvents.has(item.type)) {
this.#handleReportItem(item);
return;
}
this.#accumulateReportItem(item);
if (!this.isClearToSend()) {
ArrayPrototypePush(this.#reportBuffer, item);
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { test } from 'node:test';
import assert from 'node:assert';

test('fast-fail', () => {
assert.fail('fast');
});
12 changes: 12 additions & 0 deletions test/fixtures/test-runner/execution-ordered-bypass/slow.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { test } from 'node:test';
import { setTimeout as sleep } from 'node:timers/promises';
import { existsSync } from 'node:fs';

test('slow', async () => {
const goFile = process.env.NODE_TEST_GO_FILE;
for (let i = 0; i < 1200; i++) {
if (existsSync(goFile)) return;
await sleep(50);
}
throw new Error('go signal from host never arrived');
});
68 changes: 68 additions & 0 deletions test/parallel/test-runner-execution-ordered-bypass.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
// Flags: --no-warnings

import '../common/index.mjs';
import * as fixtures from '../common/fixtures.mjs';
import tmpdir from '../common/tmpdir.js';
import assert from 'node:assert';
import { writeFileSync } from 'node:fs';
import { test, run } from 'node:test';

const files = [
fixtures.path('test-runner', 'execution-ordered-bypass', 'slow.mjs'),
fixtures.path('test-runner', 'execution-ordered-bypass', 'fast-fail.mjs'),
];

test('execution-ordered events bypass FileTest declaration-order buffer', async () => {
tmpdir.refresh();
const goFile = tmpdir.resolve('execution-ordered-go');

// Force two-way concurrency. `concurrency: true` would resolve to
// `availableParallelism() - 1`, which is 1 on single-core CI runners — and
// with one slot the runner spawns the files sequentially, so fast-fail
// would never start while slow is polling.
const stream = run({
files,
isolation: 'process',
concurrency: 2,
env: { ...process.env, NODE_TEST_GO_FILE: goFile },
});

const events = [];

stream.on('test:complete', (data) => {
if (data.name === 'slow' || data.name === 'fast-fail') {
events.push(`complete:${data.name}`);
if (data.name === 'fast-fail') {
writeFileSync(goFile, '');
}
}
});

stream.on('test:fail', (data) => {
if (data.name === 'fast-fail') {
events.push(`fail:${data.name}`);
}
});

// eslint-disable-next-line no-unused-vars
for await (const _ of stream);

const completeFast = events.indexOf('complete:fast-fail');
const completeSlow = events.indexOf('complete:slow');
const failFast = events.indexOf('fail:fast-fail');

assert.notStrictEqual(completeFast, -1);
assert.notStrictEqual(completeSlow, -1);
assert.notStrictEqual(failFast, -1);

assert.ok(
completeFast < completeSlow,
`test:complete for fast-fail should arrive before slow; events=${events.join(', ')}`,
);

// test:fail is declaration-ordered, so the bypass must not affect it.
assert.ok(
failFast > completeSlow,
`test:fail for fast-fail should arrive after test:complete for slow; events=${events.join(', ')}`,
);
});
Loading