Skip to content

ffi: move DynamicLibrary disposer to native layer#63459

Open
Renegade334 wants to merge 1 commit into
nodejs:mainfrom
Renegade334:ffi-native-dispose
Open

ffi: move DynamicLibrary disposer to native layer#63459
Renegade334 wants to merge 1 commit into
nodejs:mainfrom
Renegade334:ffi-native-dispose

Conversation

@Renegade334
Copy link
Copy Markdown
Member

@Renegade334 Renegade334 commented May 20, 2026

No description provided.

@Renegade334
ffi: move DynamicLibrary disposer to native layer
ddbdf7d 
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 20, 2026

Review requested:

  • @nodejs/ffi

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. ffi Issues and PRs related to experimental Foreign Function Interface support. needs-ci PRs that need a full CI run. labels May 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (0e8fb91) to head (ddbdf7d).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #63459      +/-   ##
==========================================
- Coverage   90.06%   90.05%   -0.01%     
==========================================
  Files         714      714              
  Lines      225918   225915       -3     
  Branches    42735    42735              
==========================================
- Hits       203471   203452      -19     
- Misses      14232    14233       +1     
- Partials     8215     8230      +15
Files with missing lines Coverage Δ
lib/ffi.js 95.49% <ø> (-0.08%) ⬇️
src/node_ffi.cc 70.05% <100.00%> (+0.04%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334 Renegade334 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
mcollina
mcollina approved these changes May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 20, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/73586/

@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label May 20, 2026
ShogunPanda
ShogunPanda approved these changes May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@addaleax addaleax addaleax approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue Add this label to land a pull request using GitHub Actions. ffi Issues and PRs related to experimental Foreign Function Interface support. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Renegade334 @nodejs-github-bot @mcollina @ShogunPanda @addaleax @atlowChemi