test: remove test-node-output-v8-warning#63469
Conversation
|
|
The failures are pre-existing, canary base is usually broken to some extent currently |
|
I plan to land this once this passes the 48h mark, I don't think canary-base is subject to main/release rules, though it's not a huge deal to wait for two more days to see if anyone objects to removing these tests (the commit should be reviewed again in the big V8 upgrade PR before going into main through). Obviously "CI should be green" rules doesn't apply to a branch that's constantly broken and not even tested as-is but with V8 lkgr on top every day 😬 |
|
Would we be better off just removing this from main, if it has to go by the next major anyway? |
|
hmm, indeed even before the next v8 update, there's likely no point keeping these tests on main anyways.. |
asm.js validation is deprecated and disabled by default in V8, so there's no longer a stable user-reachable trigger for `v8::Isolate::kMessageWarning`. Remove the test. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
7a37f89 to
2f7f2a3
Compare
The base branch was changed.
|
@Renegade334 Thanks for the suggestion, changed to target main instead. |
asm.js validation is deprecated and disabled by default in V8, so there's no longer a stable user-reachable trigger for
v8::Isolate::kMessageWarning. Remove the test.Refs: https://issues.chromium.org/issues/510487707
Refs: #24365
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/7832184
Fixes: nodejs/node-v8#310