Skip to content

http: close pre-request sockets in closeIdleConnections #63470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
semimikoh wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −0
Open

http: close pre-request sockets in closeIdleConnections #63470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/_http_server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,7 @@ Server.prototype.closeIdleConnections = function closeIdleConnections() {
}

const connections = this[kConnections].idle();
Copy link
Copy Markdown
Member

@pimterry pimterry May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach does look like it works fine, but I wonder if it's changing the wrong level. Could we just make idle() return these connections as well? That would be clearer, and avoid hitting the same issue if we use idle() anywhere else.

I think this is fairly doable: I'd suggest adding a boolean field like received_data_ in the parser, set to false in Initalize, and then true in on_message_begin. Single boolean & write, so very cheap, and then ConnectionsList::Idle can return any connections where it's still false.

What do you think?

const allConnections = this[kConnections].all();

for (let i = 0, l = connections.length; i < l; i++) {
if (connections[i].socket._httpMessage && !connections[i].socket._httpMessage.finished) {
Expand All @@ -689,6 +690,12 @@ Server.prototype.closeIdleConnections = function closeIdleConnections() {

connections[i].socket.destroy();
}

for (let i = 0, l = allConnections.length; i < l; i++) {
if (allConnections[i].socket.bytesRead === 0) {
allConnections[i].socket.destroy();
}
}
};

Server.prototype.setTimeout = function setTimeout(msecs, callback) {
Expand Down
23 changes: 23 additions & 0 deletions test/parallel/test-http-server-close-idle-connections-pre-request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
'use strict';

const common = require('../common');

const { createServer } = require('http');
const { createConnection } = require('net');

const server = createServer(common.mustNotCall());

server.listen(0, '127.0.0.1', common.mustCall(() => {
const port = server.address().port;
server.once('connection', common.mustCall(() => {
server.close(common.mustCall());
server.closeIdleConnections();
setTimeout(common.mustNotCall(), common.platformTimeout(1000)).unref();
}));

const socket = createConnection(port, '127.0.0.1');

socket.on('connect', common.mustCall());
socket.on('close', common.mustCall());
socket.on('error', () => {});
}));
Loading