debugger: avoid probe timeouts on target throws#63632
Open
trivikr wants to merge 1 commit into
Open
Conversation
Probe mode expects uncaught target exceptions to end the debuggee and emit probe_target_exit. Disable exception pauses during probe setup so the target can exit instead of remaining paused until the timeout. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63632 +/- ##
==========================================
- Coverage 90.29% 90.28% -0.02%
==========================================
Files 730 730
Lines 234816 234817 +1
Branches 43955 43958 +3
==========================================
- Hits 212034 211999 -35
- Misses 14492 14537 +45
+ Partials 8290 8281 -9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flaky
test-debugger-probe-script-throwstimeout.Probe mode now explicitly disables exception pauses after enabling the
debugger. This keeps uncaught target exceptions flowing to process exit,
so probe mode reports
probe_target_exitinstead of leaving the targetpaused until the probe timeout.
Refs: https://github.com/nodejs/node/actions/runs/26599014755/job/78377475548
Error Log
Assisted-by: openai:gpt-5.5