Skip to content

async_hooks: remove legacy AsyncLocalStorage implementation#63641

Open
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:remove-async-hooks-als
Open

async_hooks: remove legacy AsyncLocalStorage implementation#63641
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:remove-async-hooks-als

Conversation

@mcollina
Copy link
Copy Markdown
Member

Remove the async_hooks-based AsyncLocalStorage fallback and the --no-async-context-frame flag, making AsyncContextFrame the sole implementation.

Remove the async_hooks-based AsyncLocalStorage fallback and the
--no-async-context-frame flag, making AsyncContextFrame the sole
implementation.
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 29, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (8d0a3b8) to head (7972ebb).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63641      +/-   ##
==========================================
- Coverage   90.29%   90.28%   -0.01%     
==========================================
  Files         730      729       -1     
  Lines      234782   234607     -175     
  Branches    43953    43910      -43     
==========================================
- Hits       211993   211825     -168     
- Misses      14501    14502       +1     
+ Partials     8288     8280       -8     
Files with missing lines Coverage Δ
lib/async_hooks.js 100.00% <100.00%> (ø)
lib/internal/async_context_frame.js 100.00% <100.00%> (ø)
src/async_context_frame.cc 100.00% <ø> (ø)
src/node_options.cc 76.55% <ø> (-0.13%) ⬇️
src/node_options.h 98.00% <ø> (-0.01%) ⬇️

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@addaleax addaleax added semver-major PRs that contain breaking changes and should be released in the next major version. async_hooks Issues and PRs related to the async hooks subsystem. async_local_storage AsyncLocalStorage labels May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

async_hooks Issues and PRs related to the async hooks subsystem. async_local_storage AsyncLocalStorage c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants