fix: stop pagination on empty response to prevent data loss#34
Merged
Conversation
Loki can return fewer entries than the requested limit at storage block boundaries and ingester splits. The previous check (batch_count < limit) treated short pages as end-of-data, silently discarding remaining entries in each chunk. Changed to match logcli behavior: paginate until an empty response. Also tracks global max timestamp across all streams (not just the last one iterated), deduplicates entries at pagination boundaries, and adds a safety check to break if the cursor reaches the chunk end. Additionally reduces default thread count from 8 to 4 and targets 200 chunks (min 1m) instead of 48 (min 5m) to improve reliability over kubectl port-forward connections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
limitat storage block boundaries/ingester splits. The old check (batch_count < limit) treated short pages as end-of-data; changed to paginate until an empty response (matchinglogclibehavior).Test plan
sum(count_over_time(...))from Grafanapytest tests/)