Skip to content

refactor: tmux setting#73

Merged
nomutin merged 8 commits into
masterfrom
refactor-tmux
Jun 28, 2026
Merged

refactor: tmux setting#73
nomutin merged 8 commits into
masterfrom
refactor-tmux

Conversation

@nomutin

@nomutin nomutin commented Jun 28, 2026

Copy link
Copy Markdown
Owner

Closes #72
Closes #68

@nomutin

nomutin commented Jun 28, 2026

Copy link
Copy Markdown
Owner Author

Review

Nice work on the tmux refactor! The pane mode / resize mode keybindings with status bar color feedback are clean. A few things I noticed:


Important: LSP autocompletion likely broken

The PR removes the LspAttach autocommand that called vim.lsp.completion.enable(true, ..., { autotrigger = true }) and replaces it with:

vim.opt.autocomplete = true
vim.opt.complete = "o"

vim.opt.autocomplete is not a valid Neovim option. This means LSP autocompletion (triggered automatically as you type) is no longer enabled. The vim.opt.complete = "o" only enables omnifunc as a completion source but requires manual trigger (Ctrl-N/Ctrl-P).

If this was intentional (you prefer manual completion only), a comment would help clarify. Otherwise, consider restoring the LspAttach autocommand with vim.lsp.completion.enable.


Minor: PR title scope

The title says "refactor: tmux setting" but the PR also changes nvim config (netrw, completion), zellij keybindings (tmux mode, many rebindings), mise config (jq moved to dev-only), vimrc, and CI workflows (luacheck install fix, tmux lint, vimscript runner). Consider updating the title to reflect the full scope, e.g. refactor: tmux, nvim, zellij configs + CI fixes.


Looks good

  • tmux config: Section headers + mode-based status bar coloring is great
  • tmux CI lint: tmux -f ... new-session -d is a solid way to validate config
  • luacheck fix: Installing via luarocks instead of apt is the right call for recent luacheck
  • nvim .luacheckrc: Correctly defines vim global for Neovim linting
  • zellij tmux mode: The tmux keybinding layer is well thought out

@nomutin
nomutin merged commit 3e1c223 into master Jun 28, 2026
9 checks passed
@nomutin
nomutin deleted the refactor-tmux branch June 28, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tmuxリファクタ zellij のカスタムレイアウト (ネスト)

1 participant