Update README for v0.0.31, and unbreak the --no-file-storage help text - #62
Merged
Conversation
The README still described the pre-v0.0.31 flag surface. It showed --solve-captchas and --use-file-storage as things you switch on, when all three of those options default to true server-side, and it did not mention --headed, --no-solve-captchas or --no-file-storage at all. --headed # was: --headless (a no-op against the default) --no-solve-captchas # was: --solve-captchas --no-file-storage # was: --use-file-storage Also: - document the session lifetime that #60 surfaced: 3 minutes idle, 15 minutes total. Neither default appeared in the README, and both are short enough that the next command fails with a bare "Session closed" without saying why - drop --headless and --solve-captchas from examples that only passed them to get the default behaviour - correct `notte page upload`. The README showed a positional `notte page upload <id> <file>`; it is a required --file flag, and the name refers to a file in the uploads store rather than a path on the caller's machine, so a local path fails with "Unable to get file: <path> for upload". The `notte files upload` step it needs first is now spelled out, as is the matching `notte files download --from session` for retrieving what `page download` produced Separately, fixes a cosmetic bug I shipped in #61. Cobra's UnquoteUsage takes the first backquoted span in a usage string as the flag's value placeholder, and the --no-file-storage description had `notte page download` in backticks, so v0.0.31 renders it as: --no-file-storage notte page download Do not attach FileStorage... as though the flag took an argument. Single quotes instead. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
| Filename | Overview |
|---|---|
| README.md | Documentation now reflects the current session defaults, opt-out flags, and upload/download command syntax; no concrete correctness issue found. |
| internal/cmd/sessionstart_optout.go | The help-text quoting fix is appropriate, but the corrected rendered signature lacks regression-test coverage required by repository guidelines. |
Prompt To Fix All With AI
### Issue 1
internal/cmd/sessionstart_optout.go:80
**Help regression lacks coverage**
This user-visible Cobra help fix has no test asserting that `--no-file-storage` renders without a value placeholder, so the malformed signature can be reintroduced without the test suite detecting it.
- Add a comment if the PR does n... ([source](https://app.greptile.com/review/custom-context?memory=instruction-0))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "docs: update README for v0.0.31, and unb..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README still described the pre-v0.0.31 flag surface — it showed
--solve-captchasand--use-file-storageas things you switch on, when all three of those options default totrueserver-side, and it didn't mention the new flags at all.--headless(a no-op against the default)--headed--solve-captchas--no-solve-captchas--use-file-storage--no-file-storageAlso fixed
Session lifetime is now documented. #60 surfaced defaults of 3 minutes idle / 15 minutes total; neither appeared in the README. Both are short enough that a long task outlives them, and the next command then fails with a bare
Session closedthat doesn't say why.notte page uploadwas documented wrong. The README showed a positionalnotte page upload <id> <file>. It's a required--fileflag, and the name refers to a file in the uploads store, not a path on the caller's machine — a local path fails withUnable to get file: <path> for upload. Thenotte files uploadstep it needs first is now spelled out, along with the matchingnotte files download --from sessionfor retrieving whatpage downloadproduces.Dropped no-op flags from examples that only passed
--headless/--solve-captchasto get the default behaviour.A cosmetic bug I shipped in #61
Cobra's
UnquoteUsagetreats the first backquoted span in a usage string as the flag's value placeholder. My--no-file-storagedescription had`notte page download`in backticks, so v0.0.31 renders it as:— as though the flag took an argument named "notte page download". Single quotes instead:
Verification
notte sessions start --helpon v0.0.31--headed,--no-solve-captchas,--no-file-storageeach exercised against the API:headless: false,solve_captchas: false,use_file_storage: falseidle_timeout_minutes: 3,max_duration_minutes: 15golangci-lint0 issues;go test ./internal/...all 10 packages pass🤖 Generated with Claude Code