docs: align contributor instructions - #3136
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Hello! Thank you for opening your first PR to npmx, @leekeh! 🚀 Here’s what will happen next:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe changes configure OXC as the VS Code formatter and update ChangesContributor workflow
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CONTRIBUTING.md`:
- Line 1239: Correct the typo in the contributor instructions by changing
“commiting” to “committing” in the staged-files guidance.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 61966bab-a555-4705-b543-cab820f14079
📒 Files selected for processing (2)
.vscode/settings.jsonCONTRIBUTING.md
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🔗 Linked issue
resolve #2523
🧭 Context
📚 Description
This is my first contribution, and I tried to take some time to enhance some things that stood out. At the same time, I'm new to this project, so let me know if something seems off.
The issue mentions that git hooks were removed, after looking into it they are actually still here, the config just moved to vite plus.
I removed the code coverage part of storybook, it was not defined and in my opinion this should be self-explanatory: if the component is defined in the UI library it should be in storybook (I see there is a ticket to add the missing ones). If some components are more reusable than others, it might be better to organize the components a bit to reflect that.
I also noticed the list of dev commands and project structure was not complete, but I figured you might only want to highlight the most relevant entries. For example, I’m not sure if you want to mention storybook or i18n commands, at least not initially.
Finally, I noticed on my first run that I could not really do much without running a connector. The document mentions only needing it for admin tasks, but I had to add it to be able to search for packages and view package info. Therefore no longer optional. If I did something wrong, lmk.