Skip to content

docs: align contributor instructions - #3136

Open
leekeh wants to merge 5 commits into
npmx-dev:mainfrom
leekeh:main
Open

docs: align contributor instructions#3136
leekeh wants to merge 5 commits into
npmx-dev:mainfrom
leekeh:main

Conversation

@leekeh

@leekeh leekeh commented Aug 4, 2026

Copy link
Copy Markdown

🔗 Linked issue

resolve #2523

🧭 Context

  • update git hooks info
  • update vscode settings to reduce formatting issues
  • starting a connector is no longer an optional step
  • update text fixture list

📚 Description

This is my first contribution, and I tried to take some time to enhance some things that stood out. At the same time, I'm new to this project, so let me know if something seems off.

The issue mentions that git hooks were removed, after looking into it they are actually still here, the config just moved to vite plus.

I removed the code coverage part of storybook, it was not defined and in my opinion this should be self-explanatory: if the component is defined in the UI library it should be in storybook (I see there is a ticket to add the missing ones). If some components are more reusable than others, it might be better to organize the components a bit to reflect that.

I also noticed the list of dev commands and project structure was not complete, but I figured you might only want to highlight the most relevant entries. For example, I’m not sure if you want to mention storybook or i18n commands, at least not initially.

Finally, I noticed on my first run that I could not really do much without running a connector. The document mentions only needing it for admin tasks, but I had to add it to be able to search for packages and view package info. Therefore no longer optional. If I did something wrong, lmk.

@vercel

vercel Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview Aug 4, 2026 6:32pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Aug 4, 2026 6:32pm
npmx-lunaria Ignored Ignored Aug 4, 2026 6:32pm

Request Review

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

Hello! Thank you for opening your first PR to npmx, @leekeh! 🚀

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f54cf0a3-407e-4bb3-968f-79f189d1538d

📥 Commits

Reviewing files that changed from the base of the PR and between 947e1a8 and a938289.

📒 Files selected for processing (1)
  • CONTRIBUTING.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • CONTRIBUTING.md

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Updated contributor guidance for prerequisites, mock connector setup, development workflows, formatting, pre-commit checks, fixture examples, Playwright snapshots, and current testing guidance.
  • Chores
    • Added recommended VS Code formatter settings for JSON, JSONC, TypeScript, Vue, and YAML files.
    • Improved consistency between editor formatting and the project’s established development standards.

Walkthrough

The changes configure OXC as the VS Code formatter and update CONTRIBUTING.md with current environment, connector, formatting, testing, fixture, hook, and Storybook guidance.

Changes

Contributor workflow

Layer / File(s) Summary
Development environment and connector setup
CONTRIBUTING.md
The guide now uses versions from package.json, documents mock connector setup, clarifies cache bypass scope, and generalises connector guidance.
Formatting and staged-file checks
.vscode/settings.json, CONTRIBUTING.md
VS Code uses oxc.oxc-vscode for supported languages. The guide documents OXC formatting and staged-file hook operations.
Test images, fixtures, and connector architecture
CONTRIBUTING.md
The Playwright image version is updated, fixture directories are listed, and an obsolete connector tree entry is removed.
Storybook contribution conventions
CONTRIBUTING.md
Obsolete coverage guidance is removed. The guide now requires Component Story Format stories.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: updating contributor documentation.
Description check ✅ Passed The description directly explains the documentation and development setting updates in the changeset.
Linked Issues check ✅ Passed The PR addresses issue [#2523] by updating outdated contributor guidance, including the Git hook workflow.
Out of Scope Changes check ✅ Passed The VS Code settings and contributor documentation changes support the stated PR objectives and issue requirements.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CONTRIBUTING.md`:
- Line 1239: Correct the typo in the contributor instructions by changing
“commiting” to “committing” in the staged-files guidance.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 61966bab-a555-4705-b543-cab820f14079

📥 Commits

Reviewing files that changed from the base of the PR and between ae1e982 and 947e1a8.

📒 Files selected for processing (2)
  • .vscode/settings.json
  • CONTRIBUTING.md

Comment thread CONTRIBUTING.md Outdated
@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CONTRIBUTING.md docs need a consistency pass

1 participant