fix(apply-repo-settings): normalize bypass_actors order before diffing

.claude/pr-reviews/nsheaps/github-actions/1/1771874092/documentation/REPORT.md

@@ -100,15 +100,15 @@ This PR delivers strong, well-structured documentation that significantly exceed
 
 ### Summary of Deductions
 
-| Category                           | Deduction | Reason                                                                |
+| Category | Deduction | Reason |
 | ---------------------------------- | --------- | --------------------------------------------------------------------- | --- | -------------------------------- |
-| Missing troubleshooting/error docs | -5        | No guidance on common failure modes                                   |
-| Missing prerequisites              | -2        | No runner/dependency requirements noted                               |
-| Incomplete edge-case docs          | -4        | maxdepth 2 limit, root-path sync naming, never-deletes implications   |
-| env-vars behavior mismatch         | -2        | README implies compose-level injection, script does GITHUB_ENV export |
-| auth-type values underdocumented   | -2        | No explanation of what each auth type requires                        |
-| Missing function docstrings        | -2        | `discover_compose_files` and `export_env_vars` lack docstrings        |
-| Minor inline comment gaps          | -1        | `                                                                     |     | true`on curl,`sort -z` rationale |
+| Missing troubleshooting/error docs | -5 | No guidance on common failure modes |
+| Missing prerequisites | -2 | No runner/dependency requirements noted |
+| Incomplete edge-case docs | -4 | maxdepth 2 limit, root-path sync naming, never-deletes implications |
+| env-vars behavior mismatch | -2 | README implies compose-level injection, script does GITHUB_ENV export |
+| auth-type values underdocumented | -2 | No explanation of what each auth type requires |
+| Missing function docstrings | -2 | `discover_compose_files` and `export_env_vars` lack docstrings |
+| Minor inline comment gaps | -1 | `                                                                     |     | true`on curl,`sort -z` rationale |
 
 ## References
 

.github/actions/apply-repo-settings/action.sh

@@ -161,11 +161,21 @@ apply_rulesets() {
       CREATED+=("$name")
     else
       # Compare current vs desired to decide if PUT is needed.
+      #
+      # `jq -S` only sorts object KEYS — it leaves array ELEMENT ORDER alone.
+      # GitHub doesn't guarantee bypass_actors[] comes back in the same order
+      # settings.yml declares them in, so a plain `-S` comparison flags a
+      # permanent false "needs update" for rulesets whose actual bypass_actors
+      # set is identical but differently ordered. Sort bypass_actors by a
+      # stable key (actor_type, actor_id) on both sides before the `-S`
+      # comparison so ordering differences don't register as drift.
+      local ruleset_filter='{name, target, enforcement, conditions, rules,
+        bypass_actors: ((.bypass_actors // []) | sort_by(.actor_type, .actor_id))}'
       local current_norm desired_norm
       current_norm="$(gh api "/repos/${OWNER}/${REPO}/rulesets/${existing_id}" \
-        --jq '{name, target, enforcement, conditions, rules, bypass_actors}' \
+        --jq "$ruleset_filter" \
         | jq -S '.')"
-      desired_norm="$(echo "$body" | jq -S '{name, target, enforcement, conditions, rules, bypass_actors}')"
+      desired_norm="$(echo "$body" | jq -S "$ruleset_filter")"
       if [[ "$current_norm" == "$desired_norm" ]]; then
         info "unchanged: $name (id=$existing_id)"
         UNCHANGED+=("$name")

LICENSE.md

@@ -11,7 +11,7 @@ Copyright (c) 2026 Nathan Heaps. All rights reserved.
 >   (https://polyformproject.org/licenses/internal-use/1.0.0), which is
 >   purpose-built for "use the software for internal business operations, do
 >   not distribute it." The one substantive adaptation is that PolyForm grants
->   rights to *"you and your company"* (whoever accepts the license), whereas
+>   rights to _"you and your company"_ (whoever accepts the license), whereas
 >   this license grants them to a **single, specifically named licensee**
 >   (Oura, defined below). That is a real difference: the licensor here is not
 >   a generic member of the licensee's organization, so the "permitted

pages/index.html

@@ -319,8 +319,7 @@ <h2>Detailed setup walkthrough</h2>
       </p>
       <pre>
 cp pages/index.html docs/index.html
-# Settings → Pages → Source: GitHub Actions (or branch /docs)</pre
-      >
+# Settings → Pages → Source: GitHub Actions (or branch /docs)</pre>
       <p>
         Then use <code>https://&lt;your-org&gt;.github.io/&lt;repo&gt;/</code> as the redirect. Any
         other HTTPS static host (Vercel, Netlify, etc.) works equally well.