Add new extraction methods to lyrics providers and drop some defunct ones#160
Open
berniyh wants to merge 11 commits into
Open
Add new extraction methods to lyrics providers and drop some defunct ones#160berniyh wants to merge 11 commits into
berniyh wants to merge 11 commits into
Conversation
added 11 commits
July 26, 2026 09:25
This allows to fetch from providers like genius that spread lyrics across multiple containers.
This was likely done to remove trailing whitespace, but in some cases it will actually drop the last character of the actual lyrics. The code runs trimmed(), which will remove trailing whitespace, so it shouldn't be required anyways.
berniyh
force-pushed
the
improve_lyrics_providers
branch
from
July 26, 2026 07:27
4046e4b to
7f335a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For quite some time, I noticed that a lot of the providers were broken. So I made an attempt to fix some of them. I also removed those for which the website was clearly defunct or down. Since all previous defaults were broken I set genius as default now, because I didn't know a better option.
Please note that I used Claude Opus 5 to implement these changes. I did try to check the changes as best as I can, but I don't know c++ too well, so feedback is appreciated.
Providers that I checked and fixed explicitely:
Ones that I checked and were working already:
Still broken. I didn't try to fix, but at least the service is still up:
No idea:
The other ones I didn't really try out, because they offered mostly regional stuff.
Edit: I noticed I still had an older email address configured. Fixed that and recommitted all with the proper one. Code is identical.