GPU Support and Minimal Working Example of Gaussian Compression with Kaczmarz Solver - #170
Open
vp314 wants to merge 14 commits into
Open
GPU Support and Minimal Working Example of Gaussian Compression with Kaczmarz Solver#170vp314 wants to merge 14 commits into
vp314 wants to merge 14 commits into
Conversation
…for GPU compatability
…for GPU compatability
…needs follow-up PR to enable GPU support
nathanielpritchard
left a comment
Member
There was a problem hiding this comment.
Looks good my only concern is making these changes for the gaussian and identity compressors and forgetting to make the same changes for the remaining compressors.
| mat_view::MV | ||
| vec_view::VV | ||
| end | ||
| Adapt.@adapt_structure KaczmarzRecipe |
Member
There was a problem hiding this comment.
Can you add a comment indicating what this does?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes minimal changes to types and tests to enable GPU support in Julia and creates a minimal working
example using the Gaussian compressor and Kaczmarz solver.
Description
Adapt.jldependency to enable simple type extensions for GPU compatabilityopfield can make use of GPU array typesMotivation and Context
Enabling GPU support is an important feature that may improve efficiency and usability of the library.
This PR adds type-agnostic arrays to ensure that GPU arrays can be used in place of CPU arrays that are the default in Julia.
How has this been tested
New test files have been added including a helper file that creates
MockArraytype for verifying the type-agnostic approach.Types of changes
Checklists:
Code and Comments
If this PR includes modification to the code base, please select all that apply.
API Documentation
Manual Documentation
Testing
@code_lowered and
@code_typed)