[Unreleased] gains the entry for #402 - #407
Merged
Merged
Conversation
#402 landed after the changelog reconstruction in #400, so the twelve entries no longer described what would ship. Thirteen now. Release-blocking rather than housekeeping: release notes go inside the SIGNED envelope and the update channel refuses to re-sign a version, so an entry missing at the cut cannot be added afterwards. Framing, which took the most thought. The defect is real and measured — an svg element's markup <style> applied document-wide, so one diagram's rules reached every other svg on the page (Chrome probe, both builds: victim svg rgb(255,0,0) on main, rgb(0,0,0) after, with the styled element red in both, so scoping cost an svg none of its own rules). But it is an ISOLATION failure, not a break-in: sanitizeSvgCss already refused @-rules and url(), so a drawing's stylesheet could never load or execute anything and still cannot. Writing it as a containment breach would be the more dramatic entry and the false one, and a reader deciding whether to update deserves the true shape of what they were exposed to. Hence "one diagram reaching another's appearance, not reaching out of the document", stated in the entry rather than left for inference. Written from the user's side — a slide with several diagrams looking wrong, and stranger the more it carried — with the mechanism after it, matching the twelve above. The panel-vs-markup detail is included because it explains why nobody saw this sooner: the stylesheet you write in the panel WAS scoped, so the feature looked correct everywhere it was tested. No slides/ or kernel/ file touched. Verified against main = 7422f4f.
Build size
Updated: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release-blocking. #402 landed after the changelog reconstruction in #400, so
[Unreleased]described twelve changes and would have shipped thirteen. One file, 16 insertions, noslides/orkernel/file touched.Release notes go inside the signed envelope, and the update channel refuses to re-sign a version. An entry missing at the cut cannot be added afterwards — which is what makes this block rather than follow.
The framing took the most thought
The defect is real and measured: an SVG element's markup
<style>applied document-wide, so one diagram's rules reached every other SVG on the page. Chrome probe, both builds — victim SVGrgb(255,0,0)on main,rgb(0,0,0)after, with the styled element red in both, so scoping cost an SVG none of its own rules.But it is an isolation failure, not a break-in.
sanitizeSvgCssalready refused@-rules andurl(), so a drawing's stylesheet could never load or execute anything, and still cannot. Writing it as a containment breach would be the more dramatic entry and the false one. Someone deciding whether to update deserves the true shape of what they were exposed to, so the entry says it outright:Written from the user's side
Lead paragraph is what someone actually saw — a slide with several diagrams looking wrong, and stranger the more it carried — with the mechanism after it, matching the twelve entries above.
The panel-vs-markup detail is kept because it explains why this survived so long: the stylesheet you write in the element panel was already scoped, so the feature looked correct everywhere anyone tested it. Only the path that takes pasted or imported SVG was unscoped.
Verified against
main=7422f4f.