fix(e2e): adopt the verifier's oauth.jwt.mode enum - #8
Merged
Conversation
auth.policy-verifier#134 replaced oauth.jwt.validate / allowInsecureDecode with mode = "verify" | "insecure-decode" and made the removed keys a boot error. The E2E clones siblings from their default branches, so the abac suite broke the moment that landed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Updates the ABAC E2E test configuration to match the auth.policy-verifier config change from oauth.jwt.validate to oauth.jwt.mode, preventing the verifier container from failing to boot when running this suite against the sibling repo’s current default branch.
Changes:
- Replace
oauth.jwt.validate = true/${?OAUTH_JWT_VALIDATE}withoauth.jwt.mode = "verify"/${?OAUTH_JWT_MODE}. - Update in-file comments to reflect the new enum-based configuration and boot-time validation behavior.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auth.policy-verifier#134 replaced
oauth.jwt.validate/allowInsecureDecodewithmode = "verify" | "insecure-decode", and made the removed keys a boot error rather than a silent default. Since this E2E clones sibling repos from their default branches,tests/abac/application.confsettingvalidate = truebreaks the verifier container as soon as that change is on the verifier's develop — which it now is.This is the minimal follow-up:
validate→mode = "verify", env overrideOAUTH_JWT_VALIDATE→OAUTH_JWT_MODE. Behavior is identical (full signature + iss/aud/typ verification); only the key spelling changed.Verified there are no other references to the removed keys under
tests/or the Makefile. CI on this PR runs the full suite against the current sibling default branches, so a green run here is the real check.🤖 Generated with Claude Code