Combuctor skinning extension - #6
Open
Xaero252 wants to merge 3 commits into
Open
Conversation
This will skin all combuctor frame elements to match the fit and finish of LadyUI. There's an ugly delay function that if it isn't present the skinning doesn't apply properly, and I could never figure out why. This works perfectly, though. Perhaps I need to use a different event.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote this a couple of years ago - it includes an ugly wait function - however I'm not certain it's required anymore. I couldn't find a way other than this that worked. I'm not sure why but checking against:
if addon='Combuctor'doesn't ever fire.Adding
BAG_OPENand firing against that doesn't work, either asBAG_OPENdoesn't ever actually fire in this version of the game.perhaps making Combuctor an OptionalDep would make it work without this kludgy delay.