Skip to content

fix(release): cut-rc.yml's hotcrm smoke warning no longer claims pre-exit re-arms the gate #14610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baozhoutao merged 1 commit into from
Sep 2, 2026
Merged

fix(release): cut-rc.yml's hotcrm smoke warning no longer claims pre-exit re-arms the gate #14610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/cut-rc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -866,11 +866,11 @@ jobs:
echo "@objectstack/cli@$(jq -r '.version' packages/cli/package.json) is on main at ${LOCAL}."

# Pre-publish gate #2035, kept in step with release.yml's publish job rather
# than dropped for speed. In pre mode (which the guard step proved is active,
# so ALWAYS on this lane) the #3600 amendment makes it advisory: a major
# train exists to ship deliberate surface removals, and a migrated hotcrm
# cannot exist until the rc artifacts it would migrate against are published.
# It reports; it cannot block.
# than dropped for speed. This step is advisory by construction — it has no
# BLOCKING switch — because this lane only ever runs in pre mode (the guard
# step above proved it active). It reports; it cannot block. For why the
# equivalent gate in release.yml is currently advisory too, and what re-arms
# it, see that step's own comment.
- name: Downstream backward-compat smoke (live hotcrm, advisory in pre mode)
if: ${{ !inputs.dry_run }}
env:
Expand All @@ -879,7 +879,7 @@ jobs:
if bash scripts/downstream-smoke.sh; then
echo "::notice::hotcrm@${HOTCRM_REF} is still compatible with the pre-release train."
else
echo "::warning::hotcrm@${HOTCRM_REF} is incompatible with the pre-release train — expected for this window's deliberate removals. Ship a migrated hotcrm release and bump HOTCRM_REF in release.yml before 'changeset pre exit' re-arms that gate."
echo "::warning::hotcrm@${HOTCRM_REF} is incompatible with the pre-release train — expected for this window's deliberate removals. Ship a migrated hotcrm release, bump it, and set BLOCKING=1 in .github/workflows/release.yml to re-arm this gate."
fi

# ────────────────────────────────────────────────────────────────────────
Expand Down
Loading