docs(ci, AGENTS.md): the merge queue runs the affected set, not the full package list — two stale sentences corrected - #16573
Draft
claude[bot] wants to merge 1 commit into
Conversation
… list Two present-tense sentences still described CI's queue scoping as it was before the affected-set change landed (#16453 / PR #16471, 2026-09-07): - AGENTS.md section 7, "Re-arm awareness" -- the parenthetical explaining why a queue red lands on a package the PR never touched. The current answer is that the queue's affected set is computed against the merge GROUP's base, so it spans every entry in the group, not just this PR's diff. Rewrapped inside the existing two lines: AGENTS.md stays at 1068 lines, its ratchet ceiling, headroom 0. No ceiling was raised. - scripts/check-cross-package-test-inputs.mjs, the Layer B paragraph -- the full-list build is now `push` on `main` alone; the merge queue is named as a former one so the next paragraph's past-tense sentence about #7802 keeps its antecedent. Line-neutral, 3 lines to 3 lines. Text only. No CI behaviour, no executable line, publishes nothing. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vbw3RPgdtqesx4azk9SbW8
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16479
Two sentences still described CI's merge-queue scoping as it was before #16453 (PR #16471, merged 2026-09-07T03:37:21Z). Both are corrected here; nothing else changes. Text only — no CI behaviour is touched.
What is true on
maintodayscripts/ci/select-shard-packages.shdecidesTest Core's package set per event:pull_requestmerge-base(origin/BASE_REF, HEAD), unioned with the cross-package scansmerge_groupbase_sha, with the same unionpushSo
pushonmainis the one build that still partitions the full package list — and it stays that way until #16467 lands, which then owns that sentence again. Both corrections say only what is true today.Correction 1 —
AGENTS.md§7 (Multi-agent working discipline, "Re-arm awareness")Before:
After:
The sentence's job is to explain why a queue red lands on a package the PR never touched. The old answer (the queue ran everything) is gone; the current answer is that the queue's affected set is computed against the GROUP's base, so it covers every entry in the group, not just this PR's diff. Same register, same length, same advice.
Correction 2 —
scripts/check-cross-package-test-inputs.mjsheader, Layer BBefore:
After:
Layer B's argument is unchanged: a full-list build still replays a cached green, which is why full-list coverage was never the protection. The full-list build is now
pushalone; the queue is named as a former one so the next paragraph —Layer B is why the merge queue did not catch it, past tense about #7802 — keeps its antecedent.The line pin — measured, not recalled
The card cited
AGENTS.mdat 1058/1058 — fold-paid. That number is stale (it is the count this repo'sAGENTS.mdhad before PR #15885 landed). The real mechanism and the real reading:pnpm check:pm-skill-ratchet→scripts/pm/check-skill-line-ratchet.mjs,CEILINGS.['AGENTS.md', 1068]— raised 1058 → 1068 by PR docs(agents): a localmerge-treeof an os-regen path is not GitHub mergeability — state the corollary and name the sound probe (#15871) #15885 (the merge-tree corollary), re-pinned at the landed count, headroom 0.origin/mainmeasureswc -l AGENTS.md= 1068. The pin is AT its ceiling.So the correction had to be line-neutral, and it is: the replacement text is rewrapped inside the existing two lines (57 → 56 characters of parenthetical),
wc -lafter the edit is still 1068, and the widest line in the touched paragraph is unchanged at 93 bytes (budget 120,MAX_LINE_BYTES). ⛔ No ceiling was raised. The second ratchet in that file,MAX_TABLE_ROW_BYTES(['AGENTS.md', 768]), is untouched — no table row is in the diff.The script header is not ratcheted; its correction is line-neutral anyway (3 lines → 3 lines).
Verification
node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackderived 38 commands from this diff (2 paths). Every one was run and reconciled with--ran. Results are in the report on #16479; the families that actually read these two files:pnpm check:pm-skill-ratchet— theAGENTS.mdline pin (1068/1068).pnpm check:pm-governed-prose,pnpm check:pm-governed-merges,pnpm check:pm-skill-id-lint— theAGENTS.mdreading gates.pnpm check:cross-package-test-inputs— the edited script's own gate, pluscheck:self-test-wired,check:scripts-symbol-anchors,check:comment-mask-corpus,check:published-list-mirrors,check:declaration-mirrors.pnpm check:nul-bytes, plus a manual control-character sweep over both files.⛔ The heavy test fleet was deliberately not run: no executable line is in this diff.
Changeset
skip-changeset. PerAGENTS.md§Prime Directives item 3, that label is for a diff that publishes nothing from any released package — a repo-root instruction file and a repo script's comment header publish nothing. ⛔ The label is NOT applied here: the dispatch reserved repository labels to the PM for this card, which conflicts with the standing dev clause that the author applies it on PR open. Flagged in the report; the PM applies it.Landing
This PR is governed (
AGENTS.mdis a governed surface — one hit governs the whole PR). It stays DRAFT: no ready flip, no auto-merge, no queue. It waits for a maintainer's hand merge.维护者速读(草稿)
改了什么 — 两句关于 CI 合并队列跑多少测试的描述句,一句在
AGENTS.md§7,一句在scripts/check-cross-package-test-inputs.mjs的文件头注释。只改文字,不改任何 CI 行为、不改任何可执行代码。为什么改 — PR #16471(卡 #16453)已经把合并队列从「跑全量包」改成「跑该合并组的受影响包集」。这两句仍按旧事实写,一句还是 agent 每次排队失败时照着诊断的那句,读错会把一次正常的连带红判成自己的问题。现在只有
main上的push还跑全量;#16467 落地后这句归它再改一次。风险与代价(含回滚) — 风险接近零:纯文本,无行为面。
AGENTS.md的行数上限 1068 已经顶格,本次改动做成了行数中性(改后仍是 1068 行),⛔ 没有抬任何棘轮上限。回滚就是 revert 这一个 commit,无迁移、无发布物、无 changeset。席位意见 — (留空,待复核席填)
你要做的 — 读一遍两处 before/after,认可后手工合并这个 PR(受管面,⛔ 不走队列)。
🤖 Generated with Claude Code
https://claude.ai/code/session_01Vbw3RPgdtqesx4azk9SbW8
Generated by Claude Code