Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .changeset/6768-mock-import-original.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
---

Test-only change: 25 test files that partially mock `@object-ui/react` now inherit the
real export surface via `importOriginal` instead of hand-listing exports. No published
behaviour changes — no source file is touched, and no assertion was edited or deleted.

A hand-listed mock freezes its export surface at whatever the author typed that day, so
the next export any widely-imported module reads at module scope kills those files at
COLLECTION — zero failed assertions, the file's tests never run, and the red suite reads
like flake. Spreading the real module makes the mock a superset, so a transitive consumer
can never trip over an export the test never meant to replace.
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ const getItem = vi.fn();
const toastError = vi.fn();

vi.mock('sonner', () => ({ toast: { error: (...a: unknown[]) => toastError(...a) } }));
vi.mock('@object-ui/react', () => ({ useAction: () => ({ execute }) }));
vi.mock('@object-ui/react', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
useAction: () => ({ execute }),
}));
vi.mock('../../providers/MetadataProvider', () => ({ useMetadata: () => ({ getItem }) }));

import { useNavActionDispatch } from '../useNavActionDispatch';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ let mockObjectList: Array<Record<string, unknown>> = [];
vi.mock('@object-ui/auth', () => ({
createAuthenticatedFetch: () => fetchSpy,
}));
vi.mock('@object-ui/react', () => ({
vi.mock('@object-ui/react', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
useAdapter: () => ({ find: vi.fn(async () => []) }),
}));
vi.mock('./useMetadata', () => ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import { describe, expect, it, vi } from 'vitest';
import { render, screen, waitFor } from '@testing-library/react';
import { AssignedUsersSection } from './AssignedUsersSection';

vi.mock('@object-ui/react', () => ({
vi.mock('@object-ui/react', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
useAdapter: () => mockAdapter,
}));
vi.mock('@object-ui/fields', () => ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ const state = vi.hoisted(() => {
// graphs. LookupField's own behaviour (search, hydration through `id_field`,
// commit-on-select) is covered in the fields package — this suite verifies
// the WIRING: which cell renders per kind, and what binding it receives.
vi.mock('@object-ui/react', () => ({
vi.mock('@object-ui/react', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
useAdapter: () => state.adapter,
// @object-ui/components wires this at module scope (related-count-store).
subscribeDataChanges: () => () => {},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ const state = vi.hoisted(() => {
};
});

vi.mock('@object-ui/react', () => ({
vi.mock('@object-ui/react', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
useAdapter: () => null,
// @object-ui/components wires this at module scope (related-count-store).
subscribeDataChanges: () => () => {},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ const { schemaSpy } = vi.hoisted(() => ({ schemaSpy: vi.fn() }));
vi.mock('../../InterfaceListPage', () => ({
InterfaceListPage: () => <div data-testid="mock-interface-list" />,
}));
vi.mock('@object-ui/react', () => ({
vi.mock('@object-ui/react', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ schema }: { schema: any }) => {
schemaSpy(schema);
return <div data-testid="mock-schema-renderer" />;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ import type { DashboardComponentSchema } from '@object-ui/types';

// Mock SchemaRenderer to avoid pulling in the full renderer tree.
// Forwards className and includes an interactive child to simulate real chart content.
vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ schema, className }: { schema: any; className?: string }) => (
<div data-testid="schema-renderer" className={className}>
<button data-testid={`interactive-child-${schema?.type ?? 'unknown'}`}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ const stub = {
objectSchema: { managedBy: 'platform' } as any,
};

vi.mock('@object-ui/react', () => ({
vi.mock('@object-ui/react', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
useRecordContext: () => ({
objectName: 'crm_lead',
recordId: 'rec_1',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,10 @@ const stub = {
// really calls `useContext` before the `!ctx` early return in production, and
// that leading real-hook is what makes a fewer-hooks re-render throw #310. A
// plain `() => value` stub would call no real hook, silently masking the bug.
vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
useRecordContext: () => (React.useRef(0), stub.recordCtx),
useHighlightFieldNames: () => (React.useRef(0), [] as string[]),
useSafeFieldLabel: () => (React.useRef(0), {
Expand Down
3 changes: 2 additions & 1 deletion packages/plugin-gantt/src/useGanttTranslation.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ import { renderHook } from '@testing-library/react';
let hostDict: Record<string, string> = {};
const hostT = (key: string) => hostDict[key] ?? key;

vi.mock('@object-ui/react', () => ({
vi.mock('@object-ui/react', async (importOriginal) => ({
...(await importOriginal<Record<string, unknown>>()),
useObjectTranslation: () => ({ t: hostT, language: 'zh' }),
}));

Expand Down
3 changes: 2 additions & 1 deletion packages/plugin-timeline/src/ObjectTimeline.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,10 @@ import { ObjectTimeline } from './ObjectTimeline';
import { DataSource } from '@object-ui/types';

// Mock useDataScope and useNavigationOverlay
vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
useDataScope: () => undefined,
useNavigationOverlay: () => ({
isOverlay: false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,10 @@ import { render, waitFor } from '@testing-library/react';
import { ObjectView } from '../ObjectView';
import type { ObjectViewSchema } from '@object-ui/types';

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ schema }: any) => <div data-testid="schema-renderer">{schema?.type}</div>,
SchemaRendererContext: React.createContext(null),
subscribeDataChanges: () => () => {},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,10 @@ import type { ObjectViewSchema } from '@object-ui/types';
/** Every non-empty row array `ObjectView` hands the child view, in order. */
const deliveries: any[][] = [];

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
// Records the `data` prop, which is the seam the defect is visible at:
// ObjectView passes `data={data}` down, suppressing the child's own fetch.
SchemaRenderer: ({ schema, data }: any) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,10 @@ import { convertSortToQueryParams } from '@object-ui/core';
import { ObjectView } from '../ObjectView';
import type { ObjectViewSchema } from '@object-ui/types';

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ schema }: any) => <div data-testid="schema-renderer">{schema?.type}</div>,
SchemaRendererContext: React.createContext(null),
subscribeDataChanges: () => () => {},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,10 @@ import { ObjectView } from '../ObjectView';
// Mock @object-ui/react to avoid circular dependency issues (same shape as
// ObjectView.test.tsx — the bus exports are imported at module-eval time by the
// real @object-ui/components, so a strict mock must expose them).
vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ schema }: any) => (
<div data-testid="schema-renderer" data-schema-type={schema?.type}>
{schema?.type}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,10 @@ import '@testing-library/jest-dom';
import type { DataSource } from '@object-ui/types';
import { ObjectView } from '../ObjectView';

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ schema }: any) => (
<div data-testid="schema-renderer" data-schema-type={schema?.type}>
{schema?.type}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,10 @@ const rendered: any[] = [];
/** Every schema handed to the ViewSwitcher, in order. */
const switcherSchemas: any[] = [];

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ schema }: any) => {
rendered.push(schema);
return <div data-testid="schema-renderer">{schema?.type}</div>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,10 @@ import type { ObjectViewSchema } from '@object-ui/types';
/** Every schema the view hands to SchemaRenderer, in order. */
const rendered: any[] = [];

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ schema }: any) => {
rendered.push(schema);
return <div data-testid="schema-renderer">{schema?.type}</div>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,10 @@ import { ObjectMapConfigSchema } from '@object-ui/types/zod';
/** Every schema the view hands to SchemaRenderer, in order. */
const rendered: any[] = [];

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ schema }: any) => {
rendered.push(schema);
return <div data-testid="schema-renderer">{schema?.type}</div>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ import { render, waitFor, act } from '@testing-library/react';
import { ObjectView } from '../ObjectView';
import type { ObjectViewSchema, DataSourceMutationEvent } from '@object-ui/types';

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ schema }: any) => (
<div data-testid="schema-renderer">{schema?.type}</div>
),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,10 @@ import { convertSortToQueryParams } from '@object-ui/core';
import { ObjectView } from '../ObjectView';
import type { ObjectViewSchema } from '@object-ui/types';

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ schema }: any) => <div data-testid="schema-renderer">{schema?.type}</div>,
SchemaRendererContext: React.createContext(null),
subscribeDataChanges: () => () => {},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,10 @@ import type { ObjectViewSchema } from '@object-ui/types';
/** Every schema the view hands to SchemaRenderer, in order. */
const rendered: any[] = [];

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ schema }: any) => {
rendered.push(schema);
return <div data-testid="schema-renderer">{schema?.type}</div>;
Expand Down
3 changes: 2 additions & 1 deletion packages/plugin-view/src/__tests__/ObjectView.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ import { ObjectView } from '../ObjectView';
import type { ObjectViewSchema, DataSource } from '@object-ui/types';

// Mock @object-ui/react to avoid circular dependency issues
vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ schema }: any) => (
<div data-testid="schema-renderer" data-schema-type={schema?.type}>
{schema?.type}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,10 @@ import type { ObjectViewSchema } from '@object-ui/types';

const deliveries: any[][] = [];

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ schema, data }: any) => {
if (Array.isArray(data) && data.length > 0) {
const g = (globalThis as any).__objectViewChurnDeliveries as any[][] | undefined;
Expand Down
3 changes: 2 additions & 1 deletion packages/plugin-view/src/__tests__/ViewSwitcher.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ import type { ViewSwitcherSchema, ViewType } from '@object-ui/types';
// Mock @object-ui/react to avoid circular dependency issues; mirrors
// ObjectView.test.tsx, including the data-invalidation bus that
// @object-ui/components imports at module-eval time.
vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ schema }: any) => (
<div data-testid="schema-renderer" data-schema-type={schema?.type}>
{schema?.type}
Expand Down
Loading