Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .changeset/vi-mock-inherit-guard-6849.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
---

Test/tooling only; nothing published changes.

Adds `scripts/check-vi-mock-inherit.mjs`, a ratchet that rejects a `vi.mock` factory
which hand-lists the exports of a covered workspace specifier instead of inheriting the
real module's export surface. The only `src/` file it touches is a plugin-view test
file, converted to the inheriting form — no runtime behaviour, no public API, no
published output changes.
35 changes: 35 additions & 0 deletions .github/workflows/vi-mock-specifiers.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,20 @@
name: Inert vi.mock Specifiers

# Two gates over ONE population, in one home. Both read the `vi.mock` call sites
# of this tree and both catch a mock that is silently not doing what it looks
# like it is doing: `check-vi-mock-specifiers.mjs` catches a specifier that
# resolves to no file (an inert stand-in), and `check-vi-mock-inherit.mjs`
# catches a factory that hand-lists its exports (a frozen export surface,
# objectui#6849). They share the call-site pattern deliberately -- a population
# that drifted between them would be a hole neither one reports -- so they share
# a workflow rather than each registering a required context of its own.
#
# The workflow `name:` and the job `name:` are therefore BROADER than the older
# of the two gates. They are left unchanged on purpose: those two strings are
# the check-run context that branch protection and
# `scripts/dependabot-merge-gate.mjs` name, and renaming a required context
# silently un-requires it.
#
# Why this is its own workflow rather than a step in `ci.yml` or `lint.yml`: a
# module mock can be written into any package, in any shape of pull request, and
# both of those workflows decide inside the job whether the change "needs a full
Expand Down Expand Up @@ -79,3 +94,23 @@ jobs:
# gate's own defect one level up.
- name: Check every relative vi.mock specifier resolves
run: node scripts/check-vi-mock-specifiers.mjs

# The sibling property of the same call sites: a factory that HAND-LISTS
# the exports it returns freezes the mock's export surface. The next
# export any module in the file's import graph reads AT MODULE SCOPE then
# kills the file during COLLECTION -- `Test Files 3 failed | 546 passed`
# with `Tests 6694 passed`, ZERO failed assertions, because the tests in
# those files never ran (objectui#6768). It reads as flake to whoever
# sees it next, and the bill lands on whoever added the export.
#
# The recogniser is SEMANTIC, never a grep for `importOriginal`: that
# spelling mis-counted eleven correct files as broken AND missed one
# broken file entirely (objectui#6849). It asks whether the factory
# OBTAINS the real module -- a callback parameter under any name, or
# `vi.importActual` of the same specifier -- and SPREADS it.
#
# Narrow by ruling: only the covered workspace specifiers in
# `COVERED_SPECIFIERS` are judged. Whole-module replacement of a local
# module is legitimate and out of scope by construction, not by exemption.
- name: Check every covered vi.mock factory inherits the real export surface
run: node scripts/check-vi-mock-inherit.mjs
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
"governed": "node scripts/check-governed-queue-guard.mjs --test",
"check:pre-install-import-graph": "node scripts/check-pre-install-import-graph.mjs",
"check:vi-mock-specifiers": "node scripts/check-vi-mock-specifiers.mjs",
"check:vi-mock-inherit": "node scripts/check-vi-mock-inherit.mjs",
"check:shell-escape-residue": "node scripts/check-shell-escape-residue.mjs",
"check:readme-exports": "node scripts/check-readme-exports.mjs",
"cli": "node packages/cli/dist/cli.js",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,15 @@ import type { ObjectViewSchema } from '@object-ui/types';
/** Every `data` prop the view handed to SchemaRenderer, in order. */
const delivered: unknown[][] = [];

vi.mock('@object-ui/react', async () => {
vi.mock('@object-ui/react', async (importOriginal) => {
const React = await import('react');
return {
// Inherit the real export surface, then override only what this pin reads.
// A hand-listed factory freezes the mock at whatever was typed that day, and
// the next export any module in this file's import graph reads at module
// scope kills the file during COLLECTION -- zero failed assertions, tests
// that never ran (objectui#6768 / #6849).
...(await importOriginal<Record<string, unknown>>()),
SchemaRenderer: ({ data }: any) => {
if (Array.isArray(data)) delivered.push(data);
return <div data-testid="schema-renderer" />;
Expand Down
Loading
Loading