Fixes #7101: drop the undeclared variant key from the dropdown-menu Delete item - #7717
Merged
Merged
Conversation
…own-menu Delete item `MenuCommandItem` (packages/types/src/overlay.ts) declares no `variant`; no menu renderer reads it. Deletes the key per the ruling (option A) rather than declaring a new capability for zero measured demand. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BAZFhALsQsGqxui8sNqM8s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7101
Ruling executed
Option A (director seat comment #7101 (comment), maintainer verbatim 「同意」, batch #28): the
variantkey leaves the Delete item inexamples/schema-catalog/src/schemas/components-overlay-dropdown-menu/with-icons.json; the item keepslabel/icon;MenuCommandItemgains NOvariant(no change underpackages/**); not a rider on any other PR.What changed
One file, one key removed (plus the preceding line's trailing comma) — exactly the expected diff shape:
{ "label": "Delete", - "icon": "trash", - "variant": "destructive" + "icon": "trash" }Mechanism verification (re-grep, per the ruling's execution constraints)
Grepped
variantacross all menu-item fixtures underexamples/schema-catalog/src/schemas/— the twocomponents-overlay-dropdown-menu/*.json,components-overlay-context-menu/basic-context-menu.json,components-overlay-menubar/application-menubar.json, andcomponents-form-command/command-menu.json:Positive control —
components-overlay-alert-dialog/*.json(buttons, whereButtonSchemadeclaresvariant) stays non-zero, confirming the grep is discriminating menu-item spelling from button spelling, not just returning zero everywhere:Zero-beyond-line-20 for menu items + non-zero control ⇒ the mechanism assumption held.
Gates (HEAD
02bc828, baseorigin/main4ce14f1)pnpm exec vitest run examples/schema-catalog/node scripts/check-changeset-presence.mjsexamples/schema-catalogis unpublished; no changeset added)node scripts/check-control-bytes.mjsnode -e "JSON.parse(...)"No
check:*gate family targets JSON fixture content directly beyond the two run above; this is a JSON-only fixture edit (nopackages/**, no TS/JS source), so no packagetypecheck/testis otherwise implicated.Generated by Claude Code