Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,24 @@ jobs:
if: steps.relevant.outputs.should_run == 'true'
run: pnpm check:unreferenced-sources

# A JSDoc `@example` on an exported hook is not decoration: call sites copy it.
# When the ruling the example encoded moves, the prose stays, and every later
# copy is seeded from the prose rather than from the code — so fixing the call
# sites without fixing the doc comment re-seeds them. That class cost two cards
# and three copied call sites (objectui#7627, objectui#7638) with nothing in CI
# able to see it; objectui#7617's `check-spec-symbol-derivation` was cited as
# covering it twice and does not — its rule 4 judges `@objectstack/spec`
# citations at member granularity and has nothing to say about prose that
# prescribes a LOCAL spelling.
#
# This step fails only when a documented symbol's own `@example` hand-spells
# what its real call sites obtain by CALLING a shared reader. Parses sources
# with `typescript` through the same scanner as the two steps above, so it
# needs the install and nothing built.
- name: Verify no doc comment prescribes a spelling a shared reader owns
if: steps.relevant.outputs.should_run == 'true'
run: pnpm check:doc-example-readers

# A build tsconfig that excludes tooling by FILE NAME (`*.test.ts`) stops
# the files that happen to be named that way and nothing else. The first
# shared helper added to a `__tests__/` directory is then a program input,
Expand Down
2 changes: 1 addition & 1 deletion content/docs/guide/ci-cd-pipeline.md

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
"check:shell-escape-residue": "node scripts/check-shell-escape-residue.mjs",
"check:readme-exports": "node scripts/check-readme-exports.mjs",
"check:unreferenced-sources": "node scripts/check-unreferenced-sources.mjs",
"check:doc-example-readers": "node scripts/check-doc-example-shared-reader.mjs",
"cli": "node packages/cli/dist/cli.js",
"objectui": "node packages/cli/dist/cli.js",
"create-plugin": "node packages/create-plugin/dist/index.js",
Expand Down
Loading
Loading