Skip to content

fix(app-shell): declare the spec's escalation.enabled default in the flow-node inspector - #8615

Merged
os-justin merged 1 commit into
mainfrom
claude/issue-6620-escalation-enabled-default
Sep 8, 2026
Merged

fix(app-shell): declare the spec's escalation.enabled default in the flow-node inspector#8615
os-justin merged 1 commit into
mainfrom
claude/issue-6620-escalation-enabled-default

Conversation

@os-justin

Copy link
Copy Markdown
Collaborator

Fixes #6620

The probe, run rather than read

The card's restart probe cannot produce the reading it asks for, exactly as the dispatch predicted. Both spellings, run on this worktree against installed @objectstack/spec 17.3.0:

# The card's spelling — root export
$ node -e "const { ApprovalEscalationSchema } = require('@objectstack/spec'); \
           console.log(JSON.stringify(ApprovalEscalationSchema.parse({ timeoutHours: 24 })));"
TypeError: Cannot read properties of undefined (reading 'parse')
    at [eval]:1:120

# The working spelling — the `automation` subpath
$ node --input-type=module -e "import { ApprovalEscalationSchema } from '@objectstack/spec/automation'; ..."
typeof schema: function
safeParse.success: true
safeParse.data: {"enabled":true,"timeoutHours":24,"action":"notify","notifySubmitter":true}
effective escalation.enabled default => true

The restart criterion is met and the divergence is live: the table declared 'false', the runtime applies true.

What changed

The flip. FLOW_NODE_CONFIG's approval group declared defaultValue: 'false' for escalation.enabled. defaultValue has exactly two consumers — confirmed by reading, as the dispatch asked:

site file what it does with it
controllerAdmits flow-node-config.ts resolves an unset showWhen controller — the gating of timeoutHours / action / escalateTo / notifySubmitter
the boolean control FlowNodeConfigField.tsx seeds the checkbox's checked state

So the one-line flip repairs the rendered toggle as well as the gating. (FlowNodeInspector.tsx's v.defaultValue is a different property — a flow variable declaration, not a FlowConfigField.)

The tripwire, armed. This is the substance of the card. flow-node-config.inactiveRetained.test.ts was described as this card's tripwire, but its assertion reads only the table and never the spec, so no spec bump could ever redden it. The reconciliation ledger in flow-node-config.spec-reconciliation.test.ts now covers the whole escalation block instead of notifySubmitter alone, in both directions, deriving every expected value by safeParse-ing a minimal block:

  • every default the spec materialises must be declared by the form with the same value;
  • and the form must declare no default the spec does not apply;
  • plus a vacuity guard, because both assertions iterate the spec's answer and would pass over an empty collection.

⛔ No literal 'true' anywhere in the assertion. A literal restates the exact claim that drifts, and would pass just as happily on the next upstream flip — which is how this one stayed invisible.

Pins updated to the new truth, not worked around. Three rows reddened from the flip, all three predicted, all three correct:

  • flow-node-config.inactiveRetained.test.ts — the absent-controller row flipped to toBeNull(), which is what its own comment instructed the next seat to do. Given a lit control (the same node with a stored enabled: false still flags controller-off), so the new toBeNull() is a measurement rather than an absence.
  • FlowNodeInspector.declaredDefault.test.tsx — PR test(app-shell): measure and pin what a declared flow-node defaultValue renders (objectui#6830) #8431's row "the offline table hides the same siblings, because it declares the gate false" now reads "REVEALS". Offline and online agree about this node for the first time.
  • the same file's #6620 boolean row, which pinned that the seed shipped no worded claim because the declaration was wrong. It now derives its expectation from the installed spec and asserts the rendered toggle carries it.

Stale text repaired. The two comments named in the dispatch, plus a third the same grep surfaced: FlowNodeConfigField.tsx's boolean branch cited "one declares the OPPOSITE of the spec" as a live secondary argument for shipping no caption. The arm-A no-caption ruling stands on its own; the discharged argument is marked as discharged so it is not cited again.

Non-regression axis

Derived from a plausible wrong fix, not from the bug's shape: revealing the sub-fields unconditionally satisfies "omitted-key nodes now reveal" completely while destroying the author's ability to switch escalation off. Pinned as a new case naming all four siblings individually — an assertion over one of them passes on a fix that leaks the other three.

Red-leg evidence — every new pin observed failing

Leg A — revert the fix ('true' back to 'false'; on-disk proof: injected 1, removed 0). The derived ledger named the divergence itself:

AssertionError: the hand-written table must state what an omitted key actually does at runtime:
  expected [ Array(1) ] to deeply equal []
+   "enabled: the form declares \"false\", the spec applies \"true\"",
AssertionError: the table declares the default the spec applies: expected 'false' to be 'true'
AssertionError: offline, the same node reveals the sibling the online schema reveals: expected null not to be null

Leg B — the wrong fix (controllerAdmits made to admit unconditionally). The non-regression pin reddened while the bug-shaped rows stayed green, which is what makes the axis discriminating:

× and hides them when the gate is stored off — the lit control for the same predicate
× a node that explicitly stores `enabled: false` still hides every sibling
AssertionError: 'Timeout (hours)' must stay hidden while the author has switched escalation off:
  expected <label …(2)></label> to be null

Both legs restored from HEAD and proven byte-identical (git diff HEAD empty; blob hash faa4b533 on disk == faa4b533 at HEAD).

Caricature — reported honestly

The mutation run was the table declares every boolean field's default as 'true'. My new pins stay green under it, and structurally must: post-fix, both boolean fields the offline table declares a default for genuinely are 'true', so no spec-derived assertion can tell "declared true because the spec says true" from "declared true because everything is true". Detecting it needs an assertion not derived from the spec — precisely the decorative literal the card rules out.

It is caught anyway, by a complementary pre-existing pin — the declaration-surface census in the same file, which pins which fields declare a default rather than their values:

× exactly ten fields declare a defaultValue, and these are they
+   "approval.lockRecord",
+   "boundary_event.boundaryConfig.interrupting",
+   "screen.waitForInput",

⇒ the two pins are complementary by design: the derived ledger checks values against the spec, the census checks membership. The broader caricature ("declare every field's default 'true'") is caught by my ledger alone, because escalation.action is a select whose spec default is 'notify' and it sits inside the same block-wide walk.

Verification

Run from the repo root, root-relative paths, nothing after a bare --.

check result
vitest run packages/app-shell/ 654 files, 6333 passed, 1 skipped, 0 failed
vitest run apps/console/ 90 files, 1072 passed
vitest run examples/console-starter/ 1 file, 9 passed
pnpm --filter @object-ui/app-shell run type-check exit 0 (tsc --noEmit and tsc -p tsconfig.test.json)
eslint on the 5 changed files exit 0, plain form
check:control-bytes OK, 6797 tracked text files
check:vi-mock-specifiers, check:esm-specifiers OK
check-changeset-presence.mjs / check-changeset-no-major.mjs OK / no major
check-governed-queue-guard.mjs --test NOT GOVERNED — 6 paths, none matched

Affected packages read from turbo ls --affected against the pinned base, not guessed: app-shell, console, and the two example consoles.

type-check really measured the teststsc -p tsconfig.test.json --listFiles lists all four edited test files, so this is not the "excluded from the project, reads green" trap.

LEG D (harness death), from the JSON reporter, not the text one: 259 suites, 0 failed, assertionResults counted 803 == numTotalTests 803, 0 anomalies — no Failed Suites, no zero-test files.

Blast radius was measured before touching any pin: across packages/app-shell/src/views/metadata-admin/ the flip alone moved 3 tests out of 2535 — the three named above, and nothing else.

Notes for the reviewer

  • Opened as draft and auto-merge deliberately not armed.
  • .changeset/6620-escalation-enabled-default.md, patch on @object-ui/app-shell (never major — objectui's major is the cross-repo pin).
  • One thing I did not touch and am flagging instead: .changeset/6794-notify-submitter-default.md still closes with "installed spec and table agree on it today" about escalation.enabled, which this PR makes false. It is an unreleased changeset owned by the release pipeline, so I left it alone rather than edit a file a release run may be consuming; my own changeset states the corrected fact and lands in the same CHANGELOG section.

🤖 Generated with Claude Code

https://claude.ai/code/session_01YBWFb5YgMU5dw8p2VKj16S


Generated by Claude Code

…e flow-node inspector

`FLOW_NODE_CONFIG`'s approval group declared `defaultValue: 'false'` for
`escalation.enabled` while the installed `@objectstack/spec` (17.3.0) defaults
the key to `true`. An approval node omitting the key escalates at runtime, but
the inspector drew the toggle OFF and hid `timeoutHours` / `action` /
`escalateTo` / `notifySubmitter` behind it.

`defaultValue` has two read sites, so the flip repairs both: `controllerAdmits`
resolves an unset `showWhen` controller through it, and the boolean control
seeds its checked state from it.

Arms the tripwire that could not have caught this: the reconciliation ledger in
`flow-node-config.spec-reconciliation.test.ts` now walks the whole escalation
block and derives every expected value from the installed
`ApprovalEscalationSchema`, in both directions, with a vacuity guard. The prior
tripwire for this key read only the hand-written table, so no spec bump could
redden it.

Pins that a stored `enabled: false` still hides every sibling — the
non-regression axis for a fix that revealed them unconditionally.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YBWFb5YgMU5dw8p2VKj16S
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 50 chunks) 3476.4 KB 3512.7 KB
Main entry chunk (gzip) 143.9 KB 350 KB
Entry file index-CNhdxlhP.js
Status PASS

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 15.67KB 5.75KB
app-shell (runtime-config.js) 20.68KB 7.36KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.06KB 3.86KB
auth (ActiveOrganizationStorage.js) 25.05KB 9.16KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.18KB 10.59KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.39KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.65KB 2.22KB
auth (SocialSignInButtons.js) 9.61KB 3.89KB
auth (UserMenu.js) 3.41KB 1.23KB
auth (auth-gate-events.js) 1.29KB 0.66KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 40.21KB 10.80KB
auth (createAuthenticatedFetch.js) 8.46KB 3.43KB
auth (index.js) 3.19KB 1.44KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 26.08KB 7.56KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.49KB 2.64KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (index.js) 1.68KB 0.73KB
collaboration (useCollaborationTranslation.js) 6.05KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 498.93KB 114.12KB
core (index.js) 7.48KB 2.96KB
create-plugin (index.js) 10.12KB 3.28KB
data-objectstack (index.js) 192.72KB 53.55KB
fields (index.js) 243.74KB 61.55KB
i18n (LocalizationContext.js) 1.76KB 0.96KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 1.22KB 0.64KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 6.57KB 2.76KB
i18n (index.js) 3.65KB 1.47KB
i18n (pickLocalized.js) 7.62KB 3.26KB
i18n (provider.js) 26.89KB 9.04KB
i18n (useDisplayLocale.js) 2.85KB 1.45KB
i18n (useObjectLabel.js) 34.34KB 9.17KB
i18n (useSafeTranslation.js) 5.60KB 2.33KB
layout (index.js) 38.84KB 10.94KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 4.39KB 1.66KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 11.71KB 4.29KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.24KB 2.16KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 5.12KB 1.74KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 15.16KB 3.68KB
plugin-calendar (index.js) 49.00KB 13.91KB
plugin-charts (index.js) 71.39KB 19.92KB
plugin-chatbot (index.js) 194.53KB 46.34KB
plugin-dashboard (index.js) 131.43KB 34.44KB
plugin-designer (index.js) 213.21KB 43.63KB
plugin-detail (index.js) 250.75KB 64.81KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 131.01KB 32.32KB
plugin-gantt (index.js) 167.16KB 40.99KB
plugin-grid (index.js) 208.30KB 56.63KB
plugin-kanban (index.js) 55.44KB 15.73KB
plugin-list (index.js) 112.74KB 27.70KB
plugin-map (index.js) 20.49KB 6.83KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 43.42KB 11.92KB
plugin-timeline (index.js) 30.10KB 8.74KB
plugin-tree (index.js) 9.33KB 3.25KB
plugin-view (index.js) 84.54KB 20.84KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 11.66KB 3.50KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 81.07KB 26.86KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.63KB 2.18KB
react (schema-input.js) 2.32KB 1.24KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (codegen.js) 6.58KB 2.74KB
sdui-parser (dashboard-widget-options.js) 3.08KB 1.30KB
sdui-parser (index.js) 5.55KB 2.45KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 20.57KB 5.88KB
sdui-parser (provenance.js) 3.66KB 1.82KB
sdui-parser (types.js) 0.28KB 0.23KB
sdui-parser (validate.js) 13.64KB 4.59KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 1.00KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 2.93KB 1.49KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 4.74KB 2.25KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 4.73KB 2.28KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 5.05KB 1.93KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.11KB 3.32KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants