Skip to content

fix(count): fix Acquire/Reset data race in Tracker (PIPE-1231) #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dylan-M wants to merge 1 commit into
base: dylanmyers/pipe-1222-data-race-exponentialbackoff
Choose a base branch
from
Open

fix(count): fix Acquire/Reset data race in Tracker (PIPE-1231) #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions generator/count/tracker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,13 @@ func (t *Tracker) Acquire() bool {
}
if t.remaining.CompareAndSwap(cur, cur-1) {
if cur-1 == 0 {
// Guard doneOnce/doneCh with mu so this terminal-permit close
// is ordered against Reset(), which reassigns them under mu.
// The lock is taken only on the last permit, so the common
// acquire path stays lock-free (atomic CAS only).
t.mu.Lock()
t.doneOnce.Do(func() { close(t.doneCh) })
t.mu.Unlock()
}
return true
}
Expand Down
Loading