Skip to content

ci: run the test suite under the race detector (PIPE-1223) #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dylan-M wants to merge 1 commit into
base: dylanmyers/pipe-1230-tcp-udp-stop-drain
Choose a base branch
from
Open

ci: run the test suite under the race detector (PIPE-1223) #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,11 @@ jobs:
go-version-file: go.mod
cache: true

- name: Run tests
- name: Run tests (race detector)
env:
CGO_ENABLED: "1"
run: |
go test ./...
make test-race

- name: Run embedded-library tests
run: |
Expand Down
6 changes: 6 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ install-tools:
test:
go test ./...

# test-race runs the full suite under the race detector. CI gates on this
# target so data races in production code fail the build (PIPE-1223). Requires
# a C toolchain (the race detector needs cgo).
test-race:
go test -race ./...

lint:
go tool revive -config .revive.toml -formatter friendly ./...

Expand Down
Loading