frontend: Demangle ScreenshotObj and OBSBasic - #13037
Open
Warchamp7 wants to merge 2 commits into
Open
Conversation
Warchamp7
added
kind/cleanup
6 tasks
PatTheMav
reviewed
Jan 19, 2026
Member
|
This currently has merge conflicts. |
Warchamp7
force-pushed
the
demangle-screenshot2
branch
2 times, most recently
from
May 8, 2026 02:05
0b2cfe8 to
c2a787e
Compare
Member
Author
Fixed. |
Warchamp7
force-pushed
the
demangle-screenshot2
branch
from
May 8, 2026 02:16
c2a787e to
548c3d1
Compare
Co-Authored-By: Clayton Groeneveld <19962531+cg2121@users.noreply.github.com>
Warchamp7
force-pushed
the
demangle-screenshot2
branch
from
August 17, 2026 21:16
548c3d1 to
d27256f
Compare
PatTheMav
requested changes
Aug 18, 2026
github-project-automation
Bot
moved this from Ready For Review
to Requires Changes
in 33.0 Release Tracker
Warchamp7
force-pushed
the
demangle-screenshot2
branch
from
August 18, 2026 20:20
d27256f to
8ceadc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a signal to ScreenshotObj so it doesn't have to directly call OBSBasic. Updated after the changes due to the Add Source dialog.
Revised version that supersedes #12186
Motivation and Context
Less friends for OBSBasic and better code.
How Has This Been Tested?
Took screenshots to make sure they still worked.
Types of changes
Checklist: