perf(stdune): avoid allocations in string and path helpers - #16230
Merged
Conversation
rgrinberg
force-pushed
the
push-uotwpxkrxnzt
branch
from
August 28, 2026 16:12
3757855 to
9366348
Compare
Expose unchecked string search operations for callers that use an integer sentinel, avoid intermediate search options in path operations, and allocate Filename.concat results in one pass. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-uotwpxkrxnzt
branch
from
August 28, 2026 16:16
9366348 to
6e38345
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes avoidable temporary allocations from frequently used string and path helpers. It adds option-free internal character searches, uses them in path decomposition, and constructs
Filename.concatresults in one pass.The dune-action-plugin path implementation now reuses the allocation-conscious
Stdune.Filename.concat. This preparatory change was split from #16224 so allocation reductions can be reviewed independently from the C-backed search optimization.