refactor: rename dune_targets to targets - #16242
Merged
Merged
Conversation
The target representation is consumed as Targets throughout the engine, cache, rules, and CLI, but each component currently aliases Dune_targets. Name the library and its main module Targets directly. Remove the aliases and update the bootstrap module roots and library dependencies to match. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The target representation is consumed as
Targetsthroughout the engine, cache, rules, and CLI, but each component currently aliasesDune_targets.Name the internal library and its main module
Targetsdirectly, remove the aliases, and update the bootstrap module roots and library dependencies to match.