fix(engine): retain action builder memo names - #16246
Merged
Merged
Conversation
Use the caller-provided memo name for both lazy and eager evaluations instead of assigning every action builder the same generic labels. This restores useful memo diagnostics without changing memoization behavior. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Action_builder.memoizeaccepts a caller-provided name but currently discards itin favor of generic labels shared by every action builder.
Retain the supplied name and append phase-specific suffixes, restoring useful
identities in memo diagnostics while keeping lazy and eager evaluations distinct.