fix(engine): collect traces from failed actions - #16250
Merged
Merged
Conversation
Validate the action result and collect its trace in sibling fibers so collection always runs and both failures can be reported. Trace events emitted by failed actions no longer go missing. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-pnmpuuvsputv
branch
from
August 29, 2026 16:24
b28a336 to
a300162
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collect action-provided trace events even when result validation reports that
the action failed. Validation and trace collection now run in sibling fibers,
so neither can prevent the other from completing and both errors remain
reportable.
The regression is covered by #16249.