fix(engine): report missing dynamic-run programs - #16251
Merged
Merged
Conversation
Encode the unresolved program name in dynamic actions instead of asserting. This lets action execution raise the normal location-aware program-not-found error covered by the preceding regression test. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-szyxvmqlywnu
branch
from
August 29, 2026 16:27
8698c0b to
ad4e787
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Represent an unresolved
dynamic-runprogram by its requested filename whenencoding the dynamic action, while retaining the structured lookup error for
execution. Missing programs now produce the normal location-aware
program-not-found diagnostic instead of an assertion failure.
The regression is covered by #16244.