feat(evaluation): validate LongMemEval-V2 smoke inputs - #1460
Open
chenncy wants to merge 4 commits into
Open
Conversation
chenncy
force-pushed
the
codex/longmemeval-v2-plan
branch
from
September 4, 2026 12:27
255cf50 to
4b567ec
Compare
chenncy
force-pushed
the
codex/longmemeval-v2-plan
branch
from
September 4, 2026 14:56
4b567ec to
44d5f3b
Compare
chenncy
marked this pull request as ready for review
September 4, 2026 16:13
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The run manifest currently uses a misleading path_sha256 key for a content digest, which is a contract/naming issue that should be corrected before consumers rely on it.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a reproducible, fail-closed validation layer for LongMemEval-V2 smoke inputs within the evaluation/ package, ensuring pinned dataset/harness identities and generating model-free “preflight” artifacts as groundwork for the broader benchmark work in #1359.
Changes:
- Introduces a pinned LongMemEval-V2 catalog + dataset-lock + smoke-manifest validation contract and harness checkout verification.
- Adds a model-free smoke-preflight implementation that writes non-overwritable
manifest.jsonandsubset.json. - Exposes the workflow via
powercontext-eval longmemeval-v2 smokeand documents usage.
File summaries
| File | Description |
|---|---|
| evaluation/src/powercontext_eval/benchmarks/longmemeval_v2/catalog.py | Adds fail-closed loaders/validators for the pinned LongMemEval-V2 inputs, manifests, and harness revision. |
| evaluation/src/powercontext_eval/benchmarks/longmemeval_v2/smoke.py | Implements model-free smoke preflight artifact preparation and provenance manifest writing. |
| evaluation/src/powercontext_eval/benchmarks/longmemeval_v2/init.py | Introduces the LongMemEval-V2 benchmark package namespace. |
| evaluation/src/powercontext_eval/cli.py | Adds a longmemeval-v2 smoke CLI command for running the preflight. |
| evaluation/tests/unit/test_longmemeval_v2_catalog.py | Adds unit tests covering catalog validation, smoke selection constraints, digest pinning, and harness commit enforcement. |
| evaluation/tests/unit/test_cli.py | Adds a CLI test ensuring the new smoke preflight command can run without a model by patching the preparation step. |
| evaluation/README.md | Documents the LongMemEval-V2 smoke input validation workflow and required lock/manifest structure. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Part of #1359.
Summary
Scope
This PR establishes reproducible smoke input validation only. It does not add the PowerContext Memory adapter, Reader/Judge execution, or benchmark scoring.
Validation
python -m pytest -c evaluation/pyproject.toml evaluation/tests/unit/test_longmemeval_v2_catalog.py -q(10 passed)ruff checkfor the changed Python filesgit diff --checkAI usage
Implemented with OpenAI Codex under human direction and review.