Add positionAreaContainingBlock option#412
Draft
jpzwarte wants to merge 2 commits into
Draft
Conversation
…not wrap the element when using position-area
✅ Deploy Preview for anchor-polyfill ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for anchor-position-wpt canceled.
|
Contributor
|
Thanks for taking a look at this! I haven't done a full review, but wanted to note the questions I will be considering when reviewing.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #411
Adds a
positionAreaContainingBlockoption (default:true) to control howposition-areais polyfilled.true(default): The target is wrapped with a<polyfill-position-area>element that approximates the containing block created byposition-area. Alignment is applied viajustify-self/align-selfon the target within that wrapper.false: No wrapper element is inserted. Instead, the polyfill resolves theposition-areaalignment to concrete inset values and applies them directly on the target. This avoids breaking selectors that depend on a direct DOM relationship (e.g.> target,+ target,:nth-child()), but comes with trade-offs around inset overrides, self-alignment, and overflow alignment (documented in the README andposition-area.html).