feat(mcp): config-file pack selection with env and CLI precedence - #1296
Draft
ohdearquant wants to merge 1 commit into
Draft
feat(mcp): config-file pack selection with env and CLI precedence#1296ohdearquant wants to merge 1 commit into
ohdearquant wants to merge 1 commit into
Conversation
The discovered configuration file can now declare the pack load list via [runtime].packs. Resolution precedence: explicit --pack, then non-empty KHIVE_PACKS, then [runtime].packs, then the kg-only default. [packs.<name>] remains backend assignment only. Precedence is documented in the CLI help, the full configuration example, and the design summary. Closes #1211.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The discovered configuration file (
khive.toml/config.toml) can now declare the pack load list via[runtime].packs, giving deployments KHIVE_PACKS parity without environment plumbing. Resolution precedence in the shared runtime-config path: explicit--pack> non-emptyKHIVE_PACKS>[runtime].packs>kg-only default.[packs.<name>]stays backend-assignment only and does not select packs for loading. Precedence is documented in the CLI help source, the configuration example, and the design summary.Closes #1211.
Testing
config_pack_selection_applies_when_no_override_is_set(red before fix: resolved["kg"]instead of the configured list)env_pack_selection_overrides_config_filecli_pack_selection_overrides_env_and_config_filepack_selection_defaults_to_kg_without_config_or_override-D warningsclean on both changed crates; workspace check clean; fmt clean.