Secure the loopback canvas API - #104
Merged
Merged
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The listener was loopback-only but trusted every local HTTP request and returned
Access-Control-Allow-Origin: *, so a browser origin could read or mutate the active board. Internal and external clients had no authentication contract.Verification
swift test --filter 'Canvas(ServerSecurity|ChatEngine)Tests|AgentSkillsInstallerTests'— 38 passed./script/check— release build + 194 tests passed./script/verify— signed release bundle validated./script/build_and_run.sh --verify— staged app launchedDeliberate non-goals / risk
/healthremains unauthenticated but still enforces Host/Origin and exposes only liveness/version metadata.127.0.0.1:7337; clients discover the exact base URL and launch capability from the private descriptor.Closes #101