Skip dev dependencies in setup.py so pip install only pulls runtime deps#145
Open
aisk wants to merge 1 commit into
Open
Skip dev dependencies in setup.py so pip install only pulls runtime deps#145aisk wants to merge 1 commit into
aisk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.pyparses every line ofrequirements.txtintoinstall_requires, which includes development and test tools such aspytest,ruff,buildandtwine. As a result,pip install python-okxinstalls all of these onto the user's machine, causing unnecessary bloat and overhead for anyone who just wants to use the SDK.parse_requirements()now stops reading at the dev-dependency marker (# dev...), sopip install python-okxonly pulls the runtime dependencies.pip install -r requirements.txtstill installs everything, since pip treats the marker as a plain comment, leaving the development and CI setup unchanged.