Keep editor content out of the footer - #43
Open
kevinherron wants to merge 1 commit into
Open
Conversation
Give the status controls their own theme-colored surface and end the clipped editor viewport at its top edge so document content cannot render behind the footer.
frivas
pushed a commit
to frivas/omawrite
that referenced
this pull request
Aug 31, 2026
Resolved by taking our test file and re-adding PR omacom#43's includes and test, which land at the same insertion point as ours.
frivas
pushed a commit
to frivas/omawrite
that referenced
this pull request
Aug 31, 2026
It had no anchors at all, so it sat at the footer's origin on top of the save icon at full opacity while everything around it was muted -- a merge artifact: PR omacom#45 placed it in a footer that PR omacom#43 had restructured, and neither conflicted textually so both landed and the button lost its position. The footer now splits the way the window does: what you can do to the file on the left, what the document is doing on the right. The icon shows the action rather than the state -- a pencil while previewing, because that click goes back to the source -- and it lifts out of the muted group while preview is on, so the mode is visible without reading anything.
frivas
added a commit
to frivas/omawrite
that referenced
this pull request
Aug 31, 2026
Resolved by taking our test file and re-adding PR omacom#43's includes and test, which land at the same insertion point as ours.
frivas
added a commit
to frivas/omawrite
that referenced
this pull request
Aug 31, 2026
It had no anchors at all, so it sat at the footer's origin on top of the save icon at full opacity while everything around it was muted -- a merge artifact: PR omacom#45 placed it in a footer that PR omacom#43 had restructured, and neither conflicted textually so both landed and the button lost its position. The footer now splits the way the window does: what you can do to the file on the left, what the document is doing on the right. The icon shows the action rather than the state -- a pencil while previewing, because that click goes back to the source -- and it lifts out of the muted group while preview is on, so the mode is visible without reading anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The footer controls and status text currently float over the editor. At some text sizes, document text and the caret remain visible underneath, causing the footer and document content to overlap.
This gives the full-width footer an opaque surface using the active theme background and clips the editor viewport exactly at the footer's top edge. The footer retains a minimum height so its fixed-size controls remain inside the opaque region at the smallest supported desktop text scale.
The save and open controls, status display, word count, theme behavior, text scaling, and search overlay remain unchanged.
Before
After